Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[서준환] 챕터 1213 #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[서준환] 챕터 1213 #102

wants to merge 2 commits into from

Conversation

Seojunhwan
Copy link
Member

이번에도 1개의 PR에 2개 제출하옵니다,,

되게 재미있네요. 내용 보고 조금씩 더 찾아보니까 다른 내용도 더 나오고 , , 양파같은 재미군요

hyesungoh
hyesungoh approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member

@hyesungoh hyesungoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

천이백십삼장 잘 읽었습니다 👍 👍

챕터_12/서준환.md
Comment on lines +24 to +27

다들 잘 아시겠지만 `ark` 라이브러리가 이 패턴을 자주 사용하는데, 실제 내부 로직을 잘 추상화하고 있어 외부에서 사용하기 좋은 것 같아요.

특히, 컴포넌트 내부에서 기본으로 보여주는 포맷팅 로직을 외부에서 필요시 커스텀하는 예시가 해당 패턴을 잘 사용한 예시라고 생각합니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 👏

챕터_12/서준환.md
Comment on lines +29 to +31
## 12.5 커스텀훅

저희도 `usehook-ts`처럼 커스텀훅 잘 만들어서 배포해보는 것은 어때요?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㄷㄷㄷㄷㄷㄷㄷㄷㄷㄷㄷ

챕터_13/서준환.md
Comment on lines +29 to +33
## 13.5 스트리밍 SSR

매번 헷갈리는 부분인데, 스트리밍 SSR의 경우 부분적으로 가져오기 때문에 초기 렌더는 빠를 수 있으나 초기 렌더링 HTML에 내용이 부족하지 않나요?,,

> 조금 찾아보니 크롤러는 스트리밍된 컨텐츠를 잘 인식하고 인덱싱 할 수 있다고 하네요! [vercel streaming seo](https://vercel.com/guides/does-streaming-affect-seo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대준대 ㄷㄷㄷㄷ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyesungoh hyesungoh hyesungoh approved these changes

@sjoleee sjoleee Awaiting requested review from sjoleee sjoleee is a code owner

@sangbooom sangbooom Awaiting requested review from sangbooom sangbooom is a code owner

@metacode22 metacode22 Awaiting requested review from metacode22 metacode22 is a code owner

@Orchemi Orchemi Awaiting requested review from Orchemi Orchemi is a code owner

@sumi-0011 sumi-0011 Awaiting requested review from sumi-0011 sumi-0011 is a code owner

@100Gyeon 100Gyeon Awaiting requested review from 100Gyeon 100Gyeon is a code owner

@WooWan WooWan Awaiting requested review from WooWan WooWan is a code owner

Assignees

@Seojunhwan Seojunhwan

Labels
챕터_12 챕터_13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Seojunhwan @hyesungoh