Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangbooom
requested review from
hyesungoh,
sjoleee,
Seojunhwan,
metacode22,
Orchemi,
sumi-0011,
100Gyeon and
WooWan
as code owners
Seojunhwan
approved these changes
Oct 20, 2024
Comment on lines
+20
to
+23
| > 이건 여담인데 lazy hydration 해보신분 있으신가요? | ||
| > react18에서 나온 selective hydration이랑은 다른거라 생각하는데 lazy hydration에 대해 어떻게들 생각하시는지 의견 궁금합니다.. | ||
| 전 드라마틱한 개선 이점이 있다고는 생각 안하지만 적용하면 좋을거라고 생각함다 | ||
| > [관련 블로그](https://helloinyong.tistory.com/323) |
There was a problem hiding this comment.
우와우 요것은 처음 배워가네요 , , 옛날엔 이렇게 처리했군요!
저도 상범님 의견과 동일하며 예전엔 server-component 개념이 없었기에 현재는 server-component를 통해 해결할 수 있는 문제긴 하네요! (pages는 아쉽네욥)
There was a problem hiding this comment.
공유해주신 링크에서 말하는 것처럼 흑마법같긴 하네요 ㅋㅋㅋㅋ
좀 더 높은 추상화를 제공하는 라이브러리도 있네요 🤔
https://github.com/thanhlmm/next-lazy-hydrate
| import {cakeFactory} from "https://example.com/modules/cakeFactory.mjs"; | ||
| ``` | ||
|
|
||
| > 리액트는 webpack을 통해서 번들링 되고, 로컬 파일 시스템이나 node_modules 디렉토리에 있는 모듈을 참조하도록 설계되어 있어서 안 됨. 사실 리액트 아니여도 이렇게 안쓰지 않나 🤔 |
There was a problem hiding this comment.
deno 런타임에서의 동작이나 https://esm.sh/에선 외부 소스로부터 저렇게 가져오긴 하더라구요!
hyesungoh
approved these changes
Oct 20, 2024
Comment on lines
+20
to
+23
| > 이건 여담인데 lazy hydration 해보신분 있으신가요? | ||
| > react18에서 나온 selective hydration이랑은 다른거라 생각하는데 lazy hydration에 대해 어떻게들 생각하시는지 의견 궁금합니다.. | ||
| 전 드라마틱한 개선 이점이 있다고는 생각 안하지만 적용하면 좋을거라고 생각함다 | ||
| > [관련 블로그](https://helloinyong.tistory.com/323) |
There was a problem hiding this comment.
공유해주신 링크에서 말하는 것처럼 흑마법같긴 하네요 ㅋㅋㅋㅋ
좀 더 높은 추상화를 제공하는 라이브러리도 있네요 🤔
https://github.com/thanhlmm/next-lazy-hydrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.