[백지연] 챕터 7: 자바스크립트 디자인 패턴 (3/3) #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100Gyeon
requested review from
hyesungoh,
sjoleee,
Seojunhwan,
sangbooom,
metacode22,
Orchemi,
sumi-0011 and
WooWan
as code owners
hyesungoh
approved these changes
Nov 12, 2024
|
|
||
| - 관계를 추적하기 어려울 수 있음 | ||
|
|
||
| > 책에서는 언급하지 않았지만 메모리 누수가 발생할 수 있다는 단점도 있어요 |
There was a problem hiding this comment.
제가 부족해서 잘 모르겠는데 😢, 어떤 경우에 메모리 누수가 발생하는 걸까요 ??
There was a problem hiding this comment.
아마도 옵저버 객체가 주체에 계속 남아있는 경우를 말씀하시는 것 같아요 💭 unSubscribe 를 하지 않으면 메모리 누수가 발생할 수 있다?!
There was a problem hiding this comment.
맞아요! 상범님이 남겨주신 경우를 생각했습니다 ㅎㅎ
sangbooom
approved these changes
Nov 12, 2024
Comment on lines
+628
to
+638
| - 실행 시점을 유연하게 조정하고 호출을 매개변수화 | ||
| - 명령을 실행하는 객체와 명령을 내리는 객체 간의 느슨한 결합을 통해 객체 변경에 대한 유연성을 향상시킴 | ||
| - 명령을 실행하는 객체와 명령을 내리는 객체의 책임을 분리하는 게 기본 원칙 | ||
|
|
||
| > 네이버에서 웹 기반 그래픽 편집기를 개발할 때 커맨드 패턴을 적용했다고 해요👍 | ||
| > https://youtu.be/IaIFGYWDuuo?t=2365 | ||
| > | ||
| > [영상에 나온 팁] | ||
| > | ||
| > - Command 객체의 undo, redo를 일일이 구현하지 않으려면 immutability 활용하면 된다. | ||
| > - immer를 이용하면 상위 클래스에서 undo, redo 한 번만 구현하고 하위 클래스에서는 상속받아 쓰면 된다. |
There was a problem hiding this comment.
오호.. 분리와 캡슐화가 핵심인거 같네요 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.