Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WooWan
requested review from
hyesungoh,
sjoleee,
Seojunhwan,
sangbooom,
metacode22,
Orchemi,
sumi-0011 and
100Gyeon
as code owners
100Gyeon
approved these changes
Nov 26, 2024
Comment on lines
+62
to
+64
| vscode는 최근에 amd로 작성된 모듈들을 esm 으로 마이그레이션하여 bundle size가 10%를 줄였다고 한다. | ||
|
|
||
| https://code.visualstudio.com/updates/v1_94#_esm-is-shipping-for-vs-code |
Comment on lines
+77
to
+89
| node 23 부터 require(esm) 을 지원한다. | ||
|
|
||
| https://github.com/nodejs/node/pull/51977 | ||
|
|
||
| ```js | ||
| // main.js | ||
| const required = require('./point.mjs'); | ||
|
|
||
| (async () => { | ||
| const imported = await import('./point.mjs'); | ||
| console.log(imported === required); // true | ||
| })(); | ||
| ``` |
hyesungoh
approved these changes
Nov 29, 2024
Comment on lines
+62
to
+64
| vscode는 최근에 amd로 작성된 모듈들을 esm 으로 마이그레이션하여 bundle size가 10%를 줄였다고 한다. | ||
|
|
||
| https://code.visualstudio.com/updates/v1_94#_esm-is-shipping-for-vs-code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.