Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Switch] Fix rendering in IE 11 and Safari #17095

Merged
merged 3 commits into from
Aug 22, 2019
Merged

[Switch] Fix rendering in IE 11 and Safari #17095

merged 3 commits into from
Aug 22, 2019

Conversation

rbrishabh
Copy link
Contributor

@rbrishabh rbrishabh commented Aug 21, 2019

Fixes #17029
Fixes #16812

Hey @oliviertassinari !

Is this what was required?

Thanks !

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 21, 2019

Details of bundle changes.

Comparing: b560362...58cab40

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.01% -0.02% 329,393 329,350 89,969 89,948
@material-ui/core/Paper 0.00% 0.00% 68,774 68,774 20,490 20,490
@material-ui/core/Paper.esm 0.00% 0.00% 62,148 62,148 19,215 19,215
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,137 2,137
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,614 1,614
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,829 5,829
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,058 1,058
@material-ui/lab 0.00% 0.00% 153,240 153,240 46,690 46,690
@material-ui/styles 0.00% 0.00% 51,492 51,492 15,307 15,307
@material-ui/system 0.00% 0.00% 15,658 15,658 4,370 4,370
Button 0.00% 0.00% 78,778 78,778 24,069 24,069
Modal 0.00% 0.00% 14,346 14,346 5,011 5,011
Portal 0.00% 0.00% 2,907 2,907 1,319 1,319
Rating 0.00% 0.00% 70,245 70,245 21,940 21,940
Slider 0.00% 0.00% 74,483 74,483 23,063 23,063
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 53,510 53,510 13,854 13,854
docs.main 0.00% 0.00% 597,188 597,188 190,715 190,715
packages/material-ui/build/umd/material-ui.production.min.js -0.01% -0.02% 300,308 300,265 86,409 86,390

Generated by 🚫 dangerJS against 58cab40

@oliviertassinari oliviertassinari changed the title Fixes - Poor switch animation in mobile safari [Switch] Fix rendering in IE 11 and Safari Aug 21, 2019
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: switch This is the name of the generic UI component, not the React module! labels Aug 21, 2019
@oliviertassinari
Copy link
Member

@rbrishabh It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: switch This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor switch animation in mobile safari IE11: switch thumb disappears
3 participants