-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to be compatible with Leaflet 1.3.1 #10
Comments
I can confirm that this plugin does not run out-of-the-box when using Leaflet 1.0. |
The way to go now seems to be one of the following ways:
The current implementation uses the approach of "Changing parts of an existing class (replacing how a class method works)" and this seems to be to tightly coupled to unforeseeable changes in upcoming versions of LeafletJS. |
But to keep the backwards-compatibility for automatically annotating web maps already created with Leaflet, the Leaflet-Schema.org-Dubine Core integration should continue to be tightly coupled with at least the following items of the Leaflet Standard API: Marker, CircleMarker, Popup, ImageOverlay and GeoJSON (as does Leaflet.annotate 0.3 do through building annotations on custom properties in the respective |
No description provided.
The text was updated successfully, but these errors were encountered: