Upgrade winapi related deps #6178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes dependency on old socket2 which in turn removes one link to the transitive winapi dependency
|
There is some build error here that I have to look into... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just saw that
winapi-utiljust released a version finally migrating fromwinapitowindows-sys(BurntSushi/winapi-util#13 (comment)). So I created this branch to bump the dependency. Not that it gets rid ofwinapifrom our dependency tree, but one step in that direction.I then looked at
cargo tree --all-targetsand identified another place where we could actually shrink our dependency tree a tiny bit. Bumpinghyperremoves the last dependency onsocket2 0.4which gets rid of that completely, and in turn removes another link towinapiin the meantime.So this is just a small dependency tree maintenance PR.
This change is