-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect integral underflow, NaN and inf values in the new parser #2114
Merged
sbx320
merged 8 commits into
multitheftauto:master
from
Pirulax:hotfix/new-parser-unsigned-number
Jul 3, 2023
Merged
Detect integral underflow, NaN and inf values in the new parser #2114
sbx320
merged 8 commits into
multitheftauto:master
from
Pirulax:hotfix/new-parser-unsigned-number
Jul 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pirulax
force-pushed
the
hotfix/new-parser-unsigned-number
branch
from
March 10, 2021 21:48
5d96857
to
86de824
Compare
This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically. |
This draft pull request was closed because it has been marked stale for 30 days with no activity. |
5 tasks
…tfix/new-parser-unsigned-number
…x/mtasa-blue into hotfix/new-parser-unsigned-number
Pirulax
changed the title
Detect integral under/overflow and NaN in new parser
Detect integral underflow, NaN and inf values in the new parser
Jul 2, 2023
sbx320
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new parser didn't deal correctly with NaN, under/overflows and
signed
tounsigned
conversions.Now it will
SetBadArgument
if the read number is:T
isunsigned
NaN
(previously this was only done for T = double/float)inf
NOTE/TODO: We really should use C++20's
std::in_range
hereFor now this doesn't do all the safety checks, but this should be "good enough" [until we switch to C++20]