Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mtaserver.conf.template #3094

Closed
wants to merge 1 commit into from
Closed

Update mtaserver.conf.template #3094

wants to merge 1 commit into from

Conversation

efexc
Copy link
Contributor

@efexc efexc commented Jul 2, 2023

I've edited it, including the recent changes (pr #3078) and also added scripts that will start automatically.

@sbx320
Copy link
Member

sbx320 commented Jul 2, 2023

The template is used to fill missing defaults in existing server configs (please don't ask me why this is done in such an odd manner...).

However resources shouldn't be automatically added to a server config, as those resources might not even be present in the local server installation.

@sbx320 sbx320 closed this Jul 2, 2023
@efexc efexc deleted the patch-4 branch July 2, 2023 23:15
@TracerDS
Copy link
Contributor

TracerDS commented Jul 3, 2023

However resources shouldn't be automatically added to a server config, as those resources might not even be present in the local server installation.

Not true. All default resources are present if you install mta server. They are also added to server's config regardless if you chose to install them or not.

@sbx320
Copy link
Member

sbx320 commented Jul 3, 2023

Yes. However a server owner may decide to not install any resources or remove default resources (and remove them from the mtaserver.conf as well).

With the change from this PR, the resources would be readded to the mtaserver.conf, which would cause the server to fail.

@TracerDS
Copy link
Contributor

TracerDS commented Jul 3, 2023

Adding resources to config doesnt cause the server to crash or shutdown. It only alerts about lack of resources but you can continue with it.
And the only way to not include resources during install is by building server from source and running property bat file. But thats obviously out of scope.
If the owner doesnt want any resources then there is no issue with removing lines from mtaserver.conf file, if he cares about the messages that is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants