Fix #3037: Add ResetPedVoice function - Bug fix #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbx320
requested changes
Jul 29, 2023
tederis
reviewed
Aug 16, 2023
StrixG
added
bugfix
Im done doing all the CPedSoundSA mess. Instead I do a bit of a trickery and manually create default voice type and id variables and set them on initialisation.
Only small refactors but it will make it easier for future refactors
TracerDS
force-pushed
the
250523_Add_resetPedVoice_function_#3037
branch
from
b6eafa3
to
f384481
Compare
In order to change that, everything else should be refactored. There are ~32 classes that inherit GetType() from CClientEntity. Its just better to leave it for future refactoring
MegadreamsBE
pushed a commit
to MegadreamsBE/mtasa-blue
that referenced
this pull request
Jun 6, 2024
…heftauto#3129) The function ResetPedVoice never worked (it was added in PR multitheftauto#3037) but now it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was bugged; it was never actually resetting ped's voice due to internal mta's logic.
Now should be fixed, function returns
truewhen the voice was successfully reset, returnsfalseif the voice was not changed (ie. player joins the server, player executesresetPedVoicewithout ever callingsetPedVoice)The old PR (#3042) was merged, so I had to make new PR