-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event "OnResourceStateChange" #3325
Add event "OnResourceStateChange" #3325
Conversation
Syntax: `onResourceStateChange ( resource changedResource, string oldState, string newState )`
I'm in favor of accepting this, but removing the |
For backwards compatibility its better to leave it for now and deprecate it when this PR gets merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please add the relevant wiki page once the nightly build has been created, following the "new feature" format (example)
* Added `onResourceStateChange` event Syntax: `onResourceStateChange ( resource changedResource, string oldState, string newState )` * Moved condition check to top * Update Refactoring is a separate issue that will be discussed in another PR
#3305
Some might say this event is pointless. But it might be a good alternative for
onResourceLoadStateChange
.It will also help resources that monitor changing resources. Connecting that event with tables and other data would be easier than tracking 3 separate events.