Merge pull request #5710 from multiversx/overridable-configs-fix

overridable configs fix
multiversx · Nov 17, 2023 · 28dfbe4 · 28dfbe4
2 parents cd89ae9 + b6b59e2
commit 28dfbe4
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/common/reflectcommon/structFieldsUpdate.go b/common/reflectcommon/structFieldsUpdate.go
@@ -96,6 +96,13 @@ func trySetTheNewValue(value *reflect.Value, newValue string) error {
 		}
 
 		value.Set(reflect.ValueOf(int(intVal)))
+	case reflect.Int32:
+		int32Val, err := strconv.ParseInt(newValue, 10, 32)
+		if err != nil {
+			return fmt.Errorf("%w: %s", errFunc(), err.Error())
+		}
+
+		value.Set(reflect.ValueOf(int32(int32Val)))
 	case reflect.Int64:
 		int64Val, err := strconv.ParseInt(newValue, 10, 64)
 		if err != nil {

diff --git a/common/reflectcommon/structFieldsUpdate_test.go b/common/reflectcommon/structFieldsUpdate_test.go
@@ -382,6 +382,20 @@ func TestAdaptStructureValueBasedOnPath(t *testing.T) {
 		require.Equal(t, expectedNewValue, cfg.StoragePruning.FullArchiveNumActivePersisters)
 	})
 
+	t.Run("should work and override int32 value", func(t *testing.T) {
+		t.Parallel()
+
+		path := "Antiflood.NumConcurrentResolverJobs"
+		cfg := &config.Config{}
+		cfg.Antiflood.NumConcurrentResolverJobs = int32(50)
+		expectedNewValue := int32(37)
+
+		err := AdaptStructureValueBasedOnPath(cfg, path, fmt.Sprintf("%d", expectedNewValue))
+		require.NoError(t, err)
+
+		require.Equal(t, expectedNewValue, cfg.Antiflood.NumConcurrentResolverJobs)
+	})
+
 	t.Run("should work and override string value on multiple levels depth", func(t *testing.T) {
 		t.Parallel()