Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend block endpoint #6691

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Dec 23, 2024

Reasoning behind the pull request

  • Fixed the problem related to the wrong hyper block nonce on a transaction that is returned by API

Proposed changes

Testing procedure

  • Check if the endpoint /transaction/:hash return the correct value for fields notarizedAtDestinationInMetaNonce, notarizedAtDestinationInMetaHash, hyperblockNonce, and hyperblockHash

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@miiu96 miiu96 self-assigned this Dec 23, 2024
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: eba1fad81e9d1c5770218c5a55c155d3c36298be
  • Current Branch: MX-16368-extend-get-block-endpoint-with-and-extra-argument
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 23122024-140523
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

sstanculeanu
sstanculeanu previously approved these changes Dec 24, 2024
Copy link
Collaborator

@sstanculeanu sstanculeanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be retargeted to a rc branch

ssd04
ssd04 previously approved these changes Dec 24, 2024
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: eba1fad81e9d1c5770218c5a55c155d3c36298be
  • Current Branch: MX-16368-extend-get-block-endpoint-with-and-extra-argument
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 24122024-150633
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@miiu96 miiu96 changed the base branch from master to rc/spica-patch-relayedv3 December 27, 2024 11:40
@miiu96 miiu96 dismissed stale reviews from ssd04 and sstanculeanu December 27, 2024 11:40

The base branch was changed.

Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

3 similar comments
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

Copy link

github-actions bot commented Jan 8, 2025

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

Copy link

github-actions bot commented Jan 8, 2025

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

sstanculeanu
sstanculeanu previously approved these changes Jan 8, 2025
ssd04
ssd04 previously approved these changes Jan 8, 2025
@sstanculeanu
Copy link
Collaborator

Run Tests:
mx-chain-testing-suite: main

@multiversx multiversx deleted a comment from github-actions bot Jan 9, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 9, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 9, 2025
@sstanculeanu sstanculeanu dismissed stale reviews from ssd04 and themself via 07627b9 January 9, 2025 09:12
@multiversx multiversx deleted a comment from github-actions bot Jan 9, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 07627b90489a4edde0a460ac8b1c76d9ca7441e5
  • Current Branch: MX-16368-extend-get-block-endpoint-with-and-extra-argument
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3
  • mx-chain-simulator-go Target Branch: rc/spica-patch-relayedv3
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 09012025-092844
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link
Collaborator

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.8.6-dev-config-54bce4bb3a -> MX-16368-extend-get-block--a90596c4d2

--- Specific errors ---

block hash does not match 1704
wrong nonce in block 855
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 282
Nr. of new ERRORS: 0
Nr. of new WARNS: 31
Nr. of PANICS: 0
Nodes with panic: []

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@sstanculeanu sstanculeanu merged commit 1a2c25d into rc/spica-patch-relayedv3 Jan 9, 2025
8 checks passed
@sstanculeanu sstanculeanu deleted the MX-16368-extend-get-block-endpoint-with-and-extra-argument branch January 9, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants