Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mx 16067 overridable configs array support #6599

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Mx 16067 overridable configs array support #6599

merged 7 commits into from
Dec 12, 2024

Conversation

axenteoctavian
Copy link
Contributor

@axenteoctavian axenteoctavian commented Nov 12, 2024 •
edited
Loading

Reasoning behind the pull request

  • support for simple array

Proposed changes

  • add support for array from toml file
  • little refactor

Testing procedure

  • unit tests
  • running the node
    image

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@axenteoctavian axenteoctavian self-assigned this Nov 12, 2024
@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 8a1e9ed20c1d980f1602d8e12af7407aebf41bf6
  • Current Branch: MX-16067-overridable-configs-array-support
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 12112024-165107
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@axenteoctavian axenteoctavian marked this pull request as ready for review November 13, 2024 08:09
@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 0fd6cedc626774315657a74fdc621148027086cb
  • Current Branch: MX-16067-overridable-configs-array-support
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 13112024-081503
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

bogdan-rosianu
bogdan-rosianu previously approved these changes Nov 13, 2024
View reviewed changes
miiu96
miiu96 previously approved these changes Nov 18, 2024
View reviewed changes
@sstanculeanu sstanculeanu changed the base branch from rc/v1.7.next1 to rc/spica-patch-mempool November 19, 2024 08:27
@sstanculeanu sstanculeanu dismissed stale reviews from miiu96 and bogdan-rosianu November 19, 2024 08:27

The base branch was changed.

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

danidrasovean
danidrasovean previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.8.4-dev-config-171a31edab -> MX-16067-overridable-confi-31bd356c28

--- Specific errors ---

block hash does not match 519
wrong nonce in block 346
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 250
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0
Nodes with panic: []

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@axenteoctavian axenteoctavian changed the base branch from rc/spica-patch-mempool to rc/spica-patch-relayedv3 December 11, 2024 13:18
@axenteoctavian axenteoctavian dismissed danidrasovean’s stale review December 11, 2024 13:18

The base branch was changed.

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

2 similar comments
@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@axenteoctavian
Copy link
Contributor Author

Run Tests:
mx-chain-simulator-go: main
mx-chain-testing-suite: main

@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 54bce4bb3ac2cb0d38aa265c9a9fd05b8680bedd
  • Current Branch: master
  • mx-chain-go Target Branch: ``
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 11122024-150653
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 8b3918403bfe809c8c6d479947cd41420f003797
  • Current Branch: MX-16067-overridable-configs-array-support
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 11122024-150917
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

danidrasovean
danidrasovean approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.8.4-dev-config-171a31edab -> MX-16067-overridable-confi-31bd356c28

--- Specific errors ---

block hash does not match 519
wrong nonce in block 346
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 250
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0
Nodes with panic: []

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@axenteoctavian axenteoctavian merged commit c5f7e5a into rc/spica-patch-relayedv3 Dec 12, 2024
8 checks passed
@axenteoctavian axenteoctavian deleted the MX-16067-overridable-configs-array-support branch December 12, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danidrasovean danidrasovean danidrasovean approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

@miiu96 miiu96 miiu96 approved these changes

Assignees

@axenteoctavian axenteoctavian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@axenteoctavian @miiu96 @bogdan-rosianu @danidrasovean @sstanculeanu