Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/relayedv3 #6632

Open
wants to merge 55 commits into
base: rc/spica-patch-relayedv3
Choose a base branch
from
Open

Feat/relayedv3 #6632

wants to merge 55 commits into from

Conversation

sstanculeanu
Copy link
Collaborator

@sstanculeanu sstanculeanu commented Nov 25, 2024

Reasoning behind the pull request

  • new relayed tx v3 implementation proposed, which should work exactly as a regular transaction but fees are paid by a relayer, which should be included on a new field of the transaction

Proposed changes

  • implement relayed v3 that now holds relayerAddr and relayerSignature as new fields
  • process transaction as a regular tx, but consume fees from the relayer
  • this tx requires an extra 50.000 gas for the relayed operation

Testing procedure

  • standard system test + relayed txs scenarios

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Nov 25, 2024
@sstanculeanu sstanculeanu changed the base branch from rc/spica-patch-mempool to rc/spica-patch-relayedv3 November 28, 2024 15:31
@multiversx multiversx deleted a comment from github-actions bot Dec 16, 2024
@multiversx multiversx deleted a comment from github-actions bot Dec 16, 2024
@multiversx multiversx deleted a comment from github-actions bot Dec 16, 2024
@multiversx multiversx deleted a comment from github-actions bot Dec 16, 2024
@multiversx multiversx deleted a comment from github-actions bot Dec 16, 2024
@multiversx multiversx deleted a comment from github-actions bot Dec 16, 2024
@multiversx multiversx deleted a comment from github-actions bot Dec 20, 2024
@multiversx multiversx deleted a comment from github-actions bot Dec 20, 2024
@multiversx multiversx deleted a comment from github-actions bot Dec 20, 2024
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 3b3e5cdd2d132586d27c323f7ccdb8401aa6cb8e
  • Current Branch: feat/relayedv3
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3
  • mx-chain-simulator-go Target Branch: relayedv3
  • mx-chain-testing-suite Target Branch: refactor_gas_calculation_relayed_v3

🚀 Environment Variables:

  • TIMESTAMP: 20122024-140650
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 67.39659% with 134 lines in your changes missing coverage. Please review.

Project coverage is 78.63%. Comparing base (98a029a) to head (3b3e5cd).
Report is 17 commits behind head on rc/spica-patch-relayedv3.

Files with missing lines Patch % Lines
process/smartContract/processorV2/processV2.go 69.76% 21 Missing and 5 partials ⚠️
process/transaction/baseProcess.go 39.53% 15 Missing and 11 partials ⚠️
node/node.go 32.00% 12 Missing and 5 partials ⚠️
process/transaction/shardProcess.go 73.43% 10 Missing and 7 partials ⚠️
...external/transactionAPI/apiTransactionProcessor.go 33.33% 5 Missing and 3 partials ⚠️
node/external/transactionAPI/unmarshaller.go 33.33% 4 Missing and 4 partials ⚠️
process/transaction/interceptedTransaction.go 80.95% 4 Missing and 4 partials ⚠️
process/dataValidators/txValidator.go 78.12% 6 Missing and 1 partial ⚠️
.../external/transactionAPI/gasUsedAndFeeProcessor.go 75.00% 2 Missing and 3 partials ⚠️
process/economics/economicsData.go 50.00% 2 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@                     Coverage Diff                      @@
##           rc/spica-patch-relayedv3    #6632      +/-   ##
============================================================
- Coverage                     78.68%   78.63%   -0.06%     
============================================================
  Files                           755      756       +1     
  Lines                         99368    99641     +273     
============================================================
+ Hits                          78188    78349     +161     
- Misses                        15900    15976      +76     
- Partials                       5280     5316      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andreibancioiu and others added 6 commits January 8, 2025 12:16
Co-authored-by: Sorin Stanculeanu <34831323+sstanculeanu@users.noreply.github.com>
Co-authored-by: Sorin Stanculeanu <34831323+sstanculeanu@users.noreply.github.com>
Co-authored-by: Sorin Stanculeanu <34831323+sstanculeanu@users.noreply.github.com>
On Node API, adjust processing type for relayed V3
Copy link

github-actions bot commented Jan 9, 2025

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

sstanculeanu and others added 3 commits January 9, 2025 17:14
…o_feat_rv3_2025.01.09

Merge rc spica patch rv3 into feat rv3 2025.01.09
Copy link

github-actions bot commented Jan 9, 2025

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

Copy link

github-actions bot commented Jan 9, 2025

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants