Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header verification after equivalent proofs #6659

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

  • leader sig should not be removed while checking the header signature

Proposed changes

  • avoid removing the leader signature

Testing procedure

  • with feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Dec 6, 2024
@sstanculeanu sstanculeanu self-assigned this Dec 6, 2024
@AdoAdoAdo AdoAdoAdo merged commit d0ec90f into feat/equivalent-messages Dec 11, 2024
5 checks passed
@AdoAdoAdo AdoAdoAdo deleted the fix_header_verification branch December 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants