Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Clean incoming header processor argument and checks #6668

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Dec 11, 2024

Reasoning behind the pull request

  • Clean incoming header processor argument and checks

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Dec 11, 2024
@mariusmihaic mariusmihaic marked this pull request as ready for review December 11, 2024 13:02
sasurobert
sasurobert previously approved these changes Dec 11, 2024
axenteoctavian
axenteoctavian previously approved these changes Dec 12, 2024
Base automatically changed from MX-15667-sovereign-header-version-creator to feat/chain-go-sdk December 13, 2024 08:23
@mariusmihaic mariusmihaic dismissed stale reviews from axenteoctavian and sasurobert December 13, 2024 08:23

The base branch was changed.

@mariusmihaic mariusmihaic merged commit d699ffd into feat/chain-go-sdk Dec 13, 2024
4 checks passed
@mariusmihaic mariusmihaic deleted the MX-15513-incoming-header-proc-cleanup branch December 13, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants