[sovereign] Clean incoming header processor argument and checks

factory/disabled/incomingHeaderProcessor.go

@@ -0,0 +1,26 @@
+package disabled
+
+import (
+	"github.com/multiversx/mx-chain-core-go/data"
+	"github.com/multiversx/mx-chain-core-go/data/block"
+	"github.com/multiversx/mx-chain-core-go/data/sovereign"
+)
+
+// IncomingHeaderProcessor is a disabled incoming header processor
+type IncomingHeaderProcessor struct {
+}
+
+// AddHeader does nothing
+func (ihp *IncomingHeaderProcessor) AddHeader(_ []byte, _ sovereign.IncomingHeaderHandler) error {
+	return nil
+}
+
+// CreateExtendedHeader returns an empty extended shard header
+func (ihp *IncomingHeaderProcessor) CreateExtendedHeader(_ sovereign.IncomingHeaderHandler) (data.ShardHeaderExtendedHandler, error) {
+	return &block.ShardHeaderExtended{Header: &block.HeaderV2{}}, nil
+}
+
+// IsInterfaceNil checks if the underlying pointer is nil
+func (ihp *IncomingHeaderProcessor) IsInterfaceNil() bool {
+	return ihp == nil
+}

factory/processing/processComponents.go

@@ -2119,6 +2119,9 @@ func checkProcessComponentsArgs(args ProcessComponentsFactoryArgs) error {
 	if check.IfNil(args.RunTypeComponents.OutportDataProviderFactory()) {
 		return fmt.Errorf("%s: %w", baseErrMessage, errorsMx.ErrNilOutportDataProviderFactory)
 	}
+	if check.IfNil(args.IncomingHeaderSubscriber) {
+		return fmt.Errorf("%s: %w", baseErrMessage, errorsMx.ErrNilIncomingHeaderSubscriber)
+	}
 
 	return nil
 }

factory/processing/processComponents_test.go

@@ -1071,6 +1071,15 @@ func TestNewProcessComponentsFactory(t *testing.T) {
 		require.True(t, errors.Is(err, errorsMx.ErrNilOutportDataProviderFactory))
 		require.Nil(t, pcf)
 	})
+	t.Run("nil IncomingHeaderSubscriber should error", func(t *testing.T) {
+		t.Parallel()
+
+		args := createMockProcessComponentsFactoryArgs()
+		args.IncomingHeaderSubscriber = nil
+		pcf, err := processComp.NewProcessComponentsFactory(args)
+		require.True(t, errors.Is(err, errorsMx.ErrNilIncomingHeaderSubscriber))
+		require.Nil(t, pcf)
+	})
 	t.Run("should work", func(t *testing.T) {
 		t.Parallel()
 

integrationTests/realcomponents/processorRunner.go

@@ -21,6 +21,7 @@ import (
 	factoryCore "github.com/multiversx/mx-chain-go/factory/core"
 	factoryCrypto "github.com/multiversx/mx-chain-go/factory/crypto"
 	factoryData "github.com/multiversx/mx-chain-go/factory/data"
+	"github.com/multiversx/mx-chain-go/factory/disabled"
 	factoryNetwork "github.com/multiversx/mx-chain-go/factory/network"
 	factoryProcessing "github.com/multiversx/mx-chain-go/factory/processing"
 	"github.com/multiversx/mx-chain-go/factory/runType"
@@ -434,26 +435,27 @@ func (pr *ProcessorRunner) createProcessComponents(tb testing.TB) {
 			Version:    "test",
 			WorkingDir: pr.Config.FlagsConfig.WorkingDir,
 		},
-		SmartContractParser:     smartContractParser,
-		GasSchedule:             gasScheduleNotifier,
-		NodesCoordinator:        pr.NodesCoordinator,
-		RequestedItemsHandler:   requestedItemsHandler,
-		WhiteListHandler:        whiteListRequest,
-		WhiteListerVerifiedTxs:  whiteListerVerifiedTxs,
-		MaxRating:               pr.Config.RatingsConfig.General.MaxRating,
-		SystemSCConfig:          pr.Config.SystemSCConfig,
-		ImportStartHandler:      importStartHandler,
-		HistoryRepo:             historyRepository,
-		Data:                    pr.DataComponents,
-		CoreData:                pr.CoreComponents,
-		Crypto:                  pr.CryptoComponents,
-		State:                   pr.StateComponents,
-		Network:                 pr.NetworkComponents,
-		BootstrapComponents:     pr.BootstrapComponents,
-		StatusComponents:        pr.StatusComponents,
-		StatusCoreComponents:    pr.StatusCoreComponents,
-		TxExecutionOrderHandler: txExecutionOrderHandler,
-		RunTypeComponents:       pr.RunTypeComponents,
+		SmartContractParser:      smartContractParser,
+		GasSchedule:              gasScheduleNotifier,
+		NodesCoordinator:         pr.NodesCoordinator,
+		RequestedItemsHandler:    requestedItemsHandler,
+		WhiteListHandler:         whiteListRequest,
+		WhiteListerVerifiedTxs:   whiteListerVerifiedTxs,
+		MaxRating:                pr.Config.RatingsConfig.General.MaxRating,
+		SystemSCConfig:           pr.Config.SystemSCConfig,
+		ImportStartHandler:       importStartHandler,
+		HistoryRepo:              historyRepository,
+		Data:                     pr.DataComponents,
+		CoreData:                 pr.CoreComponents,
+		Crypto:                   pr.CryptoComponents,
+		State:                    pr.StateComponents,
+		Network:                  pr.NetworkComponents,
+		BootstrapComponents:      pr.BootstrapComponents,
+		StatusComponents:         pr.StatusComponents,
+		StatusCoreComponents:     pr.StatusCoreComponents,
+		TxExecutionOrderHandler:  txExecutionOrderHandler,
+		RunTypeComponents:        pr.RunTypeComponents,
+		IncomingHeaderSubscriber: &disabled.IncomingHeaderProcessor{},
 	}
 
 	processFactory, err := factoryProcessing.NewProcessComponentsFactory(argsProcess)

node/nodeRunner.go

@@ -43,6 +43,7 @@ import (
 	coreComp "github.com/multiversx/mx-chain-go/factory/core"
 	cryptoComp "github.com/multiversx/mx-chain-go/factory/crypto"
 	dataComp "github.com/multiversx/mx-chain-go/factory/data"
+	factoryDisabled "github.com/multiversx/mx-chain-go/factory/disabled"
 	heartbeatComp "github.com/multiversx/mx-chain-go/factory/heartbeat"
 	networkComp "github.com/multiversx/mx-chain-go/factory/network"
 	processComp "github.com/multiversx/mx-chain-go/factory/processing"
@@ -1236,33 +1237,34 @@ func (nr *nodeRunner) CreateManagedProcessComponents(
 	txExecutionOrderHandler := ordering.NewOrderedCollection()
 
 	processArgs := processComp.ProcessComponentsFactoryArgs{
-		Config:                  *configs.GeneralConfig,
-		EpochConfig:             *configs.EpochConfig,
-		RoundConfig:             *configs.RoundConfig,
-		PrefConfigs:             *configs.PreferencesConfig,
-		ImportDBConfig:          *configs.ImportDbConfig,
-		EconomicsConfig:         *configs.EconomicsConfig,
-		SmartContractParser:     smartContractParser,
-		GasSchedule:             gasScheduleNotifier,
-		NodesCoordinator:        nodesCoordinator,
-		Data:                    dataComponents,
-		CoreData:                coreComponents,
-		Crypto:                  cryptoComponents,
-		State:                   stateComponents,
-		Network:                 networkComponents,
-		BootstrapComponents:     bootstrapComponents,
-		StatusComponents:        statusComponents,
-		StatusCoreComponents:    statusCoreComponents,
-		RequestedItemsHandler:   requestedItemsHandler,
-		WhiteListHandler:        whiteListRequest,
-		WhiteListerVerifiedTxs:  whiteListerVerifiedTxs,
-		MaxRating:               configs.RatingsConfig.General.MaxRating,
-		SystemSCConfig:          configs.SystemSCConfig,
-		ImportStartHandler:      importStartHandler,
-		HistoryRepo:             historyRepository,
-		FlagsConfig:             *configs.FlagsConfig,
-		TxExecutionOrderHandler: txExecutionOrderHandler,
-		RunTypeComponents:       runTypeComponents,
+		Config:                   *configs.GeneralConfig,
+		EpochConfig:              *configs.EpochConfig,
+		RoundConfig:              *configs.RoundConfig,
+		PrefConfigs:              *configs.PreferencesConfig,
+		ImportDBConfig:           *configs.ImportDbConfig,
+		EconomicsConfig:          *configs.EconomicsConfig,
+		SmartContractParser:      smartContractParser,
+		GasSchedule:              gasScheduleNotifier,
+		NodesCoordinator:         nodesCoordinator,
+		Data:                     dataComponents,
+		CoreData:                 coreComponents,
+		Crypto:                   cryptoComponents,
+		State:                    stateComponents,
+		Network:                  networkComponents,
+		BootstrapComponents:      bootstrapComponents,
+		StatusComponents:         statusComponents,
+		StatusCoreComponents:     statusCoreComponents,
+		RequestedItemsHandler:    requestedItemsHandler,
+		WhiteListHandler:         whiteListRequest,
+		WhiteListerVerifiedTxs:   whiteListerVerifiedTxs,
+		MaxRating:                configs.RatingsConfig.General.MaxRating,
+		SystemSCConfig:           configs.SystemSCConfig,
+		ImportStartHandler:       importStartHandler,
+		HistoryRepo:              historyRepository,
+		FlagsConfig:              *configs.FlagsConfig,
+		TxExecutionOrderHandler:  txExecutionOrderHandler,
+		RunTypeComponents:        runTypeComponents,
+		IncomingHeaderSubscriber: &factoryDisabled.IncomingHeaderProcessor{},
 	}
 	processComponentsFactory, err := processComp.NewProcessComponentsFactory(processArgs)
 	if err != nil {

testscommon/components/components.go

@@ -667,6 +667,7 @@ func GetProcessArgs(
 				},
 			},
 		},
+		IncomingHeaderSubscriber: &sovereign.IncomingHeaderSubscriberStub{},
 	}
 
 	initialAccounts := createAccounts()