Accept relayed tx v3 with sender account non-existent #6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Dec 16, 2024
| accountHandler, err := txv.getSenderAccount(interceptedTx) | ||
| if err != nil { | ||
| if err != nil && !shouldAllowMissingSenderAccount { |
There was a problem hiding this comment.
Should we check for ErrAccountNotFound (explicitly)? Just a question.
There was a problem hiding this comment.
I don't think it is necessary, as ErrAccountNotFound is the only one returned from getSenderAccount method
| return err | ||
| } | ||
|
|
||
| return txv.checkAccount(interceptedTx, accountHandler) | ||
| } | ||
|
|
||
| func hasTxValue(interceptedTx process.InterceptedTransactionHandler) bool { |
There was a problem hiding this comment.
Indeed, we don't handle MultiESDTTransfer with EGLD in interceptor (we never did, but that is OK).
| return false | ||
| } | ||
|
|
||
| return big.NewInt(0).Cmp(txValue) < 0 |
There was a problem hiding this comment.
Maybe directly use Sign() method of txValue, without instantiating a new big int (zero)?
Base automatically changed from
MX-16294-mempool-selection-relayed
to
feat/relayedv3
December 16, 2024 08:01
sstanculeanu
dismissed
andreibancioiu’s stale review
The base branch was changed.
AdoAdoAdo
approved these changes
Dec 16, 2024
andreibancioiu
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?