stabilization-equivalent-proofs #6686
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdoAdoAdo
changed the title
…ock-sync Check proof on activation block sync
…tiversx/mx-chain-go into equivalent-proofs-feat-stabilization
| @@ -57,6 +56,13 @@ type SubroundsHandler struct { | |||
| currentConsensusType consensusStateMachineType | |||
| } | |||
|
|
|||
| func (s *SubroundsHandler) EpochConfirmed(epoch uint32, _ uint64) { | |||
| @@ -17,6 +17,7 @@ func TestEpochChangeWithNodesShufflingAndRater(t *testing.T) { | |||
| t.Skip("this is not a short test") | |||
| } | |||
|
|
|||
| _ = logger.SetLogLevel("*:DEBUG") | |||
There was a problem hiding this comment.
not to forget removing this
| @@ -203,12 +203,16 @@ func TestSyncWorksInShard_EmptyBlocksNoForks_With_EquivalentProofs(t *testing.T) | |||
| t.Skip("this is not a short test") | |||
| } | |||
|
|
|||
| _ = logger.SetLogLevel("*:DEBUG,process:TRACE,consensus:TRACE") | |||
There was a problem hiding this comment.
not to forget removing this
| @@ -56,6 +56,7 @@ func (idv *interceptedDataVerifier) Verify(interceptedData process.InterceptedDa | |||
|
|
|||
| err := interceptedData.CheckValidity() | |||
| if err != nil { | |||
| log.Debug("Intercepted data is invalid", "hash", interceptedData.Hash(), "err", err) | |||
There was a problem hiding this comment.
I think we'll need a special handle here, as interceptedData.Hash() will be the header hash, thus receiving an invalid proof for the first time will lead to always returning ErrInvalidInterceptedData for further proofs(even valid ones)
| @@ -384,6 +384,7 @@ type ForkDetector interface { | |||
| GetNotarizedHeaderHash(nonce uint64) []byte | |||
| ResetProbableHighestNonce() | |||
| SetFinalToLastCheckpoint() | |||
| // ReceivedProof() | |||
There was a problem hiding this comment.
not to forget removing this
| @@ -161,6 +162,10 @@ func (boot *baseBootstrap) requestedHeaderHash() []byte { | |||
| return boot.headerhash | |||
| } | |||
|
|
|||
| func (boot *baseBootstrap) processReceivedProof(headerProof data.HeaderProofHandler) { | |||
There was a problem hiding this comment.
not to forget the implementation
| @@ -52,13 +52,13 @@ export GENESIS_STAKE_TYPE="direct" #'delegated' or 'direct' as in direct stake | |||
| export OBSERVERS_ANTIFLOOD_DISABLE=0 | |||
|
|
|||
| # Shard structure | |||
| export SHARDCOUNT=2 | |||
| export SHARD_VALIDATORCOUNT=3 | |||
| export SHARDCOUNT=1 | |||
There was a problem hiding this comment.
this should be reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?