From b95b8159acd40b2d800723bbee1337da67d1b2c6 Mon Sep 17 00:00:00 2001 From: Hartmnt Date: Fri, 31 May 2024 12:28:14 +0000 Subject: [PATCH] FIX(ui): Remove mention of variable bitrate from UI Mumble has been using constant bitrate with Opus for a while now: https://github.com/mumble-voip/mumble/blob/7a6274f19e2d7c2ffb76b7ebcd22d0c1df9445d9/src/mumble/AudioInput.cpp#L238 All other codecs have been dropped, too. The UI still mentioned VBR in some places, this commit removes those mentions. Fixes #6414 --- src/mumble/AudioInput.ui | 2 +- src/mumble/AudioStats.ui | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mumble/AudioInput.ui b/src/mumble/AudioInput.ui index 81bba734307..ebd3445d836 100644 --- a/src/mumble/AudioInput.ui +++ b/src/mumble/AudioInput.ui @@ -608,7 +608,7 @@ Maximum bandwidth used for sending audio - <b>This shows peak outgoing bandwidth used.</b><br />This shows the peak amount of bandwidth sent out from your machine. Audio bitrate is the maximum bitrate (as we use VBR) for the audio data alone. Position is the bitrate used for positional information. Overhead is our framing and the IP packet headers (IP and UDP is 75% of this overhead). + <b>This shows peak outgoing bandwidth used.</b><br />This shows the peak amount of bandwidth sent out from your machine. Audio bitrate is the maximum bitrate for the audio data alone. Position is the bitrate used for positional information. Overhead is our framing and the IP packet headers (IP and UDP is 75% of this overhead). diff --git a/src/mumble/AudioStats.ui b/src/mumble/AudioStats.ui index c736ef74263..b9fc01e770a 100644 --- a/src/mumble/AudioStats.ui +++ b/src/mumble/AudioStats.ui @@ -181,7 +181,7 @@ Bitrate of last frame - This is the audio bitrate of the last compressed frame (20 ms), and as such will jump up and down as the VBR adjusts the quality. The peak bitrate can be adjusted in the Settings dialog. + This is the audio bitrate of the last compressed frame (20 ms). The peak bitrate can be adjusted in the Settings dialog.