FIX(server): Allow to move temporary channels provided sufficient per… #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missions Previously it was not possible to move temporary channels at all. This appears to be not deliberate as the move failed with a "denied MakeChannel" message. Most likely, this is due to an oversight in efbba85 where temporary channel movement was simply not considered. This commit fixes the ACL check to look for MakeTempChannel instead of MakeChannel when appropriate. Fixes mumble-voip#1162
Hartmnt
added
server
acl
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Hartmnt
added a commit
that referenced
this pull request
Jun 6, 2024
…ls provided sufficient per…" to 1.5.x (#6456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to move temporary channels at all. This appears to be not deliberate as the move failed with a "denied MakeChannel" message. Most likely, this is due to an oversight in efbba85 where temporary channel movement was simply not considered.
This commit fixes the ACL check to look for MakeTempChannel instead of MakeChannel when appropriate.
Fixes #1162