FIX(client): Limit size of the chat bar #6578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the chat bar QTextEdit was unlimited in screen space size and would start stretching the main window and chat log, if messages were too large. This resulted in the window becoming unusable unless you would manually resize the window down again. This commit adds a sensible limit to how much of the chat bar can be visible at once. Currently, this limit is set to 10 times the font height. After that the chat bar will stop growing in screen space and instead start showing a scrollbar. Fixes mumble-voip#6528 Fixes mumble-voip#1320
Hartmnt
added
client
ui
bug
Krzmbrzl
approved these changes
Sep 30, 2024
davidebeatrici
approved these changes
Sep 30, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Krzmbrzl
added a commit
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the chat bar QTextEdit was unlimited in screen space size and would start stretching the main window and chat log, if messages were too large.
This resulted in the window becoming unusable unless you would manually resize the window down again.
This commit adds a sensible limit to how much of the chat bar can be visible at once. Currently, this limit is set to 10 times the font height. After that the chat bar will stop growing in screen space and instead start showing a scrollbar.
Fixes #6528
Fixes #1320