WIP: Bisecting Windows crash #6661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The settings page could not be opened after the user clicked on the settings button in the main window. The problem is due to tab button ordering function. This function is called before buttons are created. That's why application throws an assertion error. Fixes mumble-voip#6421 Co-Authored-By: Abdullah Ömer Yamaç <aomeryamac@gmail.com> (cherry picked from commit c93a213)
src/mumble/GlobalShortcut.cpp:96:74: error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-Wdeprecated-this-capture]
96 | connect(eventFilter, &KeyEventObserver::keyEventObserved, this, [=]() { m_comboBox->showPopup(); });
| ^
src/mumble/GlobalShortcut.cpp:388:74: error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-Wdeprecated-this-capture]
388 | connect(eventFilter, &KeyEventObserver::keyEventObserved, this, [=]() { qtbEdit->click(); });
| ^
src/mumble/GlobalShortcut.cpp:405:12: error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-Wdeprecated-this-capture]
405 | [=]() { m_lineEdit->setFocus(Qt::MouseFocusReason); });
| ^
src/mumble/ListenerVolumeSlider.cpp:14:57: error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-Wdeprecated-this-capture]
14 | connect(&m_resetTimer, &QTimer::timeout, this, [=]() { m_currentSendDelay = 0; });
| ^
src/mumble/VolumeSliderWidgetAction.cpp:49:3: error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-Wdeprecated-this-capture]
49 | m_volumeSlider->setFocus(Qt::TabFocusReason);
| ^
src/mumble/VolumeSliderWidgetAction.cpp:55:3: error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-Wdeprecated-this-capture]
55 | m_volumeSlider->setFocus(Qt::TabFocusReason);
| ^
(cherry picked from commit c34c96d)
…settings" to 1.5.x (mumble-voip#6446)
Previously, only the "mute" and "deaf" states were saved to the settings file. However, when a user deafens themselves without muting first, Mumble will automatically unmute the user as soon as they undeafen. The "autoUnmute" state was not saved in the settings though, leading to the state "deafened (muted implied)" being reduced to "deafened and muted". This commit moves the autoUnmute state from being a local member of MainWindow to the settings file allowing to preserve the "deafened (muted implied)" state. Fixes mumble-voip#6393 (cherry picked from commit bab88eb)
…muted state across restarts" to 1.5.x (mumble-voip#6448)
…icitly in lambdas" to 1.5.x (mumble-voip#6447)
Hartmnt
force-pushed
the
bug_bisect
branch
3 times, most recently
from
2002f6e to
c0bba57
Compare
This is a workaround for a bug that appeared in a recent version of CMake. WORKING_DIRECTORY prepends the specified path to a list instead of using it directly, resulting in: cd /D D:\a\1\b\overlay\overlay_xcompile-prefix;D:\a\1\b\overlay\overlay_xcompile-prefix\src\overlay_xcompile-build For reference, this causes the build to fail on Windows with the following error: "The filename, directory name, or volume label syntax is incorrect." This commit simply removes the parameter from the ExternalProject_Add() call, since the default working directory is perfectly fine.
…endencies Looks like targets are now built concurrently, which results in the installer failing to find the G15 and x64 overlay helpers. This commit marks the G15 and overlay targets as dependencies of the client, when they're enabled. As a bonus, plugins are now tied to their own dedicated target rather than the client's. This is required because the client's subdirectory is now included later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge