Add mupen64plus appdata #49
Conversation
Not sure how I feel about "ASDIR", but "APPSTREAMDIR" threw off the indentation.
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <application> | |||
There was a problem hiding this comment.
Run appstream-util upgrade on this file.
There was a problem hiding this comment.
Also run appstream-util validate it is missing some details.
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <application> | |||
| <id type="desktop">mupen64plus.desktop</id> | |||
There was a problem hiding this comment.
Use an app-id that follows reverse dns style.
|
Updated based on review |
| @@ -0,0 +1,28 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <component type="desktop"> | |||
| <id>org.mupen64plus.Mupen64Plus</id> | |||
There was a problem hiding this comment.
Missing <launchable type="desktop-id">org.mupen64plus.Mupen64Plus.desktop</launchable>
| </screenshot> | ||
| </screenshots> | ||
| <releases> | ||
| <release date="2015-04-26" version="2.5"/> |
There was a problem hiding this comment.
Yes, but it's been a very long time since they've had a release.
(It looks like they broke up their source into a bunch of different modules in going to git hub, and have updated some of the modules, but not the "core")
| </p> | ||
| </description> | ||
| <url type="homepage">http://mupen64plus.org/</url> | ||
| <url type="help">http://mupen64plus.org/docs/</url> |
| <url type="homepage">http://mupen64plus.org/</url> | ||
| <url type="help">http://mupen64plus.org/docs/</url> | ||
| <url type="bugtracker">https://github.com/mupen64plus/mupen64plus-user-issues/issues</url> | ||
| <url type="donation">https://www.paypal.com/webapps/shoppingcart?flowlogging_id=59a5b20d47d74&mfid=1541895691620_59a5b20d47d74</url> |
There was a problem hiding this comment.
Where did you find this PayPal link? I don’t see it on the homepage.
There was a problem hiding this comment.
It's linked from here (looks like an old site):
http://mupen64.emulation64.com/
Should it be removed from this file?
There was a problem hiding this comment.
Yes; that PayPal link is for Hacktarux who as far as I know hasn’t been involved for years.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <component type="desktop"> | ||
| <id>org.mupen64plus.Mupen64Plus</id> | ||
| <launchable type="desktop-id">org.mupen64plus.Mupen64Plus</launchable> |
There was a problem hiding this comment.
| <launchable type="desktop-id">org.mupen64plus.Mupen64Plus</launchable> | |
| <launchable type="desktop-id">org.mupen64plus.Mupen64Plus.desktop</launchable> |
Catch from review...
adjust screenshot text
|
The original comments states we need a fronted to be accepted to flathub:
So I suspect it's not the good place. I've looked in synaptic and the only frontend is mupen64plus-qt, which is here: https://github.com/dh4/mupen64plus-qt Can I suggest to work with @dh4 for this? |
This file is from building a flatpak package (flathub/flathub#663)