Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mupen64plus appdata #49

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add mupen64plus appdata #49

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7845ad1
Add mupen64plus appdata
wberrier Oct 8, 2018
cc25262
appdata updates: from review feedback
wberrier Nov 11, 2018
9357cf4
desktop file: another update
wberrier Nov 11, 2018
8f55b1a
appdata: use https links
wberrier Nov 11, 2018
ffc5d12
launchable uses full desktop filename
wberrier Nov 12, 2018
1041f9e
appdata: remove obsolete donation link
wberrier Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions data/org.mupen64plus.Mupen64Plus.appdata.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<application>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run appstream-util upgrade on this file.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also run appstream-util validate it is missing some details.

<id type="desktop">mupen64plus.desktop</id>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an app-id that follows reverse dns style.

<name>Mupen64Plus</name>
<summary>Nintendo 64 Emulator</summary>
<metadata_license>CC-BY-SA-3.0</metadata_license>
<project_license>GPL-2.0+</project_license>
<description>
<p>
Mupen64plus is a Nintendo 64 Emulator.
This package includes all the plug-ins.
</p>
</description>
<url type="homepage">http://mupen64plus.org/</url>
<url type="bugtracker">https://github.com/mupen64plus/mupen64plus-user-issues/issues</url>
<screenshots>
<screenshot type="default">https://screenshots.debian.net/screenshots/000/010/356/large.png</screenshot>
</screenshots>
<releases>
<release date="2015-04-26" version="2.5"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is upstream still developed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it's been a very long time since they've had a release.

(It looks like they broke up their source into a bunch of different modules in going to git hub, and have updated some of the modules, but not the "core")

</releases>
</application>
7 changes: 7 additions & 0 deletions projects/unix/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,9 @@ endif
ifeq ($(ICONSDIR),)
ICONSDIR := $(PREFIX)/share/icons/hicolor
endif
ifeq ($(ASDIR),)
ASDIR := $(PREFIX)/share/metainfo
endif

SRCDIR = ../../src
OBJDIR = _obj$(POSTFIX)
Expand Down Expand Up @@ -280,6 +283,7 @@ targets:
@echo " MANDIR=path == path to install mupen64plus manual page (default: PREFIX/share/man)"
@echo " APPSDIR=path == path to install desktop file (default: PREFIX/share/applications)"
@echo " ICONSDIR=path == path to install icon files (default: PREFIX/share/icons/hicolor)"
@echo " ASDIR=path == path to install appstream data files (default: PREFIX/share/metainfo)"
@echo " DESTDIR=path == path to prepend to all installation paths (only for packagers)"
@echo " Debugging Options:"
@echo " DEBUG=1 == add debugging symbols to application binary"
Expand All @@ -303,13 +307,16 @@ install: $(TARGET)
$(INSTALL) -m 0644 ../../data/icons/48x48/apps/mupen64plus.png "$(DESTDIR)$(ICONSDIR)/48x48/apps"
$(INSTALL) -d "$(DESTDIR)$(ICONSDIR)/scalable/apps"
$(INSTALL) -m 0644 ../../data/icons/scalable/apps/mupen64plus.svg "$(DESTDIR)$(ICONSDIR)/scalable/apps"
$(INSTALL) -d "$(DESTDIR)$(ASDIR)"
$(INSTALL) -m 0644 ../../data/org.mupen64plus.Mupen64Plus.appdata.xml "$(DESTDIR)$(ASDIR)"


uninstall:
$(RM) "$(DESTDIR)$(BINDIR)/$(TARGET)" "$(DESTDIR)$(MANDIR)/man6/mupen64plus.6"
$(RM) "$(DESTDIR)$(APPSDIR)/mupen64plus.desktop"
$(RM) "$(DESTDIR)$(ICONSDIR)/48x48/apps/mupen64plus.png"
$(RM) "$(DESTDIR)$(ICONSDIR)/scalable/apps/mupen64plus.svg"
$(RM) "$(DESTDIR)$(ASDIR)/org.mupen64plus.Mupen64Plus.appdata.xml"


# build dependency files
Expand Down