Fix issue 1247: Remove 'inline' from 5 mididev.cpp functions

muse-sequencer · Sep 23, 2023 · 050aa29 · 050aa29
1 parent a362f7b
commit 050aa29
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/ChangeLog b/src/ChangeLog
@@ -1,3 +1,6 @@
+23.09.2023
+    - Fix issue 1247: compilation only succeeds with MODULES_BUILD_STATIC=1 (Tim)
+      Five undefined symbols. Remove 'inline' from five functions in mididev.cpp
 20.09.2023
     - Fixed issue 1243 Slow startup: Always rescanning when file contains no plugins. (Tim)
       File ladspa_dsp.so was causing rescanning all the time because it is normally empty

diff --git a/src/muse/mididev.cpp b/src/muse/mididev.cpp
@@ -863,26 +863,26 @@ float MidiDevice::getWorstSelfLatencyMidi(bool capture)
   return tli->_worstSelfLatencyMidi;
 }
 
-inline bool MidiDevice::canDominateOutputLatencyMidi(bool capture) const
+/*inline*/ bool MidiDevice::canDominateOutputLatencyMidi(bool capture) const
 {
   if(capture)
     return true;
   return false;
 }
 
-inline bool MidiDevice::canDominateInputLatencyMidi(bool /*capture*/) const
+/*inline*/ bool MidiDevice::canDominateInputLatencyMidi(bool /*capture*/) const
 {
   return false;
 }
 
-inline bool MidiDevice::canDominateEndPointLatencyMidi(bool capture) const
+/*inline*/ bool MidiDevice::canDominateEndPointLatencyMidi(bool capture) const
 {
   if(capture)
     return false;
   return true;
 }
 
-inline bool MidiDevice::canPassThruLatencyMidi(bool /*capture*/) const
+/*inline*/ bool MidiDevice::canPassThruLatencyMidi(bool /*capture*/) const
 { 
   return true;
 }
@@ -1672,7 +1672,7 @@ TrackLatencyInfo& MidiDevice::getLatencyInfoMidi(bool capture, bool input)
 //   latencyCompWriteOffset
 //---------------------------------------------------------
 
-inline unsigned long MidiDevice::latencyCompWriteOffsetMidi(bool capture) const
+/*inline*/ unsigned long MidiDevice::latencyCompWriteOffsetMidi(bool capture) const
 {
   return capture ? _captureLatencyInfo._compensatorWriteOffset : _playbackLatencyInfo._compensatorWriteOffset;
 }