Midi panic icon

[kybos]

Just a quick poll ;-) : Which one of the icons looks better and should be kept? I am not sure myself...

[terminator356]

Yeah, it did strike me as a bit odd, the proximity of the exclamation point to the drop down arrow
gave the slight impression there were three buttons there.
I think the first icon probably says it better.
But I have a request: Change the colour so that it is not such a 'loud' primary red colour.
Maybe a bit lighter, more pastel-ish? Maybe not fill the whole square?
Primary red is too 'loud'. As in, "Hey man that suit you're wearing is loud!" ;-)

[kybos]

Thanks. I did not like the second one either, that's why I was asking.
Too loud? It's midi panic after all, it's supposed to stick out ;-).
But you are possibly right that there is too much red. It works quite well on the darker themes, but on the default theme it looks a little strange...
I merged the first icon into master, just in case there is a new release soon. I will see what I can do then.

[terminator356]

Slight request: I think it is time to separate the style/fonts tab into two tabs - style and fonts.
The dialog is now too long for me and the bottom is cut off requiring alt/move just to see the Apply/OK buttons.
I could take care of it now but I don't want to step on anything you might be doing.
Should I do it or do you want to do it?

[kybos]

What is your screen resolution? The dialog is 702 (logical) pixels high (using 10pt font size), that's not so much, given a normal HD screen has 1080. I know laptop screens can be smaller, so it would be good to know what the max size of dialogs should be as a rule.
In the long term it certainly makes sense to separate the tabs anyway, there could be more options added etc. I can do it, I assume you have other things to do before the release.

[terminator356]

My screen is 1366x768 (old).
The dialog seems to be about 850 pixels high here on KDE.
I'd say 768 is usually a good maximum, at least for standard def.
It covers older standard LCD screens like this one.
But don't forget the taskbar, at least here, eats up about 40 pixels of that.

[kybos]

There is a PR for you to check ;-).
I put the style sheet path to a separate group box, also because I have more options in preparation related to the style sheets...

[spamatica]

Den tis 28 jan. 2020 kl 07:14 skrev Tim <notifications@github.com>:

My screen is 1366x768 (old). The dialog seems to be about 850 pixels high here on KDE. I'd say 768 is usually a good maximum, at least for standard def. It covers older standard LCD screens like this one.

I agree it's good to cater for 1366x768 but, really you should try to get a bigger monitor :D Though I admire your tenacity with sticking to working hardware! .\../ —

…

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/orgs/muse-sequencer/teams/musedevteam/discussions/20/comments/5?email_source=notifications&email_token=ABCFANZL5LY6GQ7HRLLL2Z3Q77ENZA5CNFSM4KMETDA2YY3PNVWWK3TUL52HS4DFWNCGS43DOVZXG2LPNZIG643UKJSXA3DZVJRW63LNMVXHIX3JMTHAAAVEHA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCFANZTNQ3WUJQRJ6VIZILQ77ENZANCNFSM4KMETDAQ> .

[kybos]

Somewhat less intrusive and I think acceptable on all 3 themes:

OK for you?

[terminator356]

Hey, that's neat! Different. I think it says a lot, being a midi function. Direct. To the point.

[spamatica]

I concurr, that's nice Den ons 29 jan. 2020 kl 15:46 skrev Tim <notifications@github.com>:

…

Hey, that's neat! Different. I think it says a lot, being a midi function. Direct. To the point. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/orgs/muse-sequencer/teams/musedevteam/discussions/20/comments/9?email_source=notifications&email_token=ABCFAN7VPUBX6IYFGDHE6UDRAGJC7A5CNFSM4KMETDA2YY3PNVWWK3TUL52HS4DFWNCGS43DOVZXG2LPNZIG643UKJSXA3DZVJRW63LNMVXHIX3JMTHAAAVFQE>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCFAN3QXWFKNE4OG7FOXXLRAGJC7ANCNFSM4KMETDAQ> .

[kybos]

Thanks guys.
I will push it tomorrow, it's on another PC...