Key signatures after section break are not transposed by transpose dialog

[sammik]

Issue type

UX/Interaction bug (incorrect behaviour)

Description with steps to reproduce

1. create score in G major
2. add section break
3. transpose next section (after break) to different key
4. see - Key signature is not transposed

Supporting files, videos and screenshots

KS-not-transposed-after-section-break.mp4

What is the latest version of MuseScore Studio where this issue is present?

nightly

Regression

No.

Operating system

Linux Mint (Ubuntu 22.04)

Additional context

Its happening, because key sig after section break is just generated key sig, not regular one.
Question here is, whether correct behaviour is to add regular key sig after section break, or if to leave it generated, and only with transpos dialog change it to standard one.

Checklist

• This report follows the guidelines for reporting bugs and issues
• I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
• I have attached all requested files and information to this report
• I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible

[sammik]

Another thing to keep in mind. If user has song with multiple sections, and want to transpose one section, subsequent sections should remain untransposed.

[pacebes]

I have tried to reproduce this issue and I think the behaviour is a bit different than described (see video):

Issue-25168-transposing.mp4

As you say Key signature is not transposed, but this happens after and before the section break. Key signature is transposed only if the selected area includes a regular signature.

Just to clarify. This issue is about is to transpose both the notes and the key signature in the selected area. Am I right?

[pacebes]

I have been looking the code (transpose.cpp) and it seems that there is some code to ensure that the key signature is transposed only if there is a change in the key of the selected area:

                bool addKey = ks->isChange();
                if ((startKey || addKey) && !ks->isAtonal()) {

So it seems that it is made this way on purpose.

[sammik]

So it seems that it is made this way on purpose.

Of course, it is.
I think, main question here is, whether section break should add Key signature (key "change"), or not. I think, in most cases, user expect it there.

Anyway, I already made PR #25260 for this issue some time ago, so feel free to test it, or comment it. Thank You.

[pacebes]

So it seems that it is made this way on purpose.

Of course, it is. I think, main question here is, whether section break should add Key signature (key "change"), or not. I think, in most cases, user expect it there.

Anyway, I already made PR #25260 for this issue some time ago, so feel free to test it, or comment it. Thank You.

I didn't notice there was already a PR, Sorry. It seems a very precise change.