Fix #17600 - Tuplets Skipped by Alt+left and Alt+right

[codecruisedor]

Make Tuplet select-able via alt+right, alt+left

Resolves: #17600

Clone of PR #18346

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[oktophonie]

This doesn't seem to work correctly to me - tuplet brackets will be included (sometimes) as you step through with alt-left/right, but the sequence seems to get thrown and many items will be skipped. I've not managed to deduce what the pattern is yet.

[shoogle]

This is a good start, but it's in the wrong place. I can tell because with your build Alt+Right skips barlines and articulations/lyrics/fermatas on the current note and goes straight to a tuplet on the next note instead:

Alt+Right should visit everything on the current note before moving on to the next note, so my guess is this code probably needs to go at the end of this function, or perhaps in Segment::nextElement() instead (because that function is called at the end of this function).

In fact, I think it should go in Segment::firstElementOfSegment(), which is called from within Segment::nextElement().

Also, you should only visit the tuplet if nextCR is the first (leftmost) ChordRest within the tuplet. If nextCR is in the middle/end of the tuplet then you shouldn't visit the tuplet.

[shoogle]

When going backwards, you shouldn't look for tuplets on the previous ChordRest (CR). Instead you would check current CR. You need to know:

1. Does the current CR have a tuplet? And if so...
2. Is the current CR the first (leftmost) CR inside the tuplet?

If the answer to both questions is "yes" then you visit the tuplet, otherwise go back to the previous CR.

[shoogle]

Good!

[shoogle]

The previous element will be something before the tuplet, not something inside the tuplet. Exceptionally, it might be an element in a different voice that occurs at the same time as the tuplet.

You probably need to call Segment::previousElement() or something like that.

[codecruisedor]

Thanks for the review, working on the changes

[Jojo-Schmitz]

Rebase needed, but see also #23082, while this here looks pretty much orphaned?

[RomanPudashkin]

Closing due to a long period of inactivity. Also, see #23082