-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line style options for text line elements #20854
base: master
Are you sure you want to change the base?
Conversation
Is it reasonable to also add "Allow diagonal", and to make it is exposed in the Properties panel? I know, that's kind of a separate issue - the fact that "allow diagonal" is currently missing from Properties for some lines. But if the goal here is to create a generally more consistent set of styles and properties, that one is very much missed right now. |
I would like to hear @oktophonie's opinion on this- as you mentioned, the option isnt exposed for all other line elements either. Perhaps more style options should be added to different line types as well. |
It's there for hairpins, but was somehow removed for other line types. It's definitely necessary in many cases for things like various harp notations, functional analysis, annotations for educational materials, graphic notation, etc. I actually just ran into this a couple of days ago and had it on my to-do list to open an issue next week. But since I saw this PR, I thought it worth bringing up here. I'm happy to just open the issue separately, though, as I was originally planning. I know there was a deliberate effort to simplify the properties panel by removing seldom-used options that don't have good use cases, but diagonal lines are hardly a niche thing. I could imagine a decision to keep "allow diagonal" off the properties panel for certain specific line types where one could reasonably say there is no reason to ever make them diagonal. But for generic staff/system text lines, I think there should be no question that is is quite necessary functionality. Workaround for now has been to enable the diagonal on a line in MU3, save the score, open the score in MU4, then add the already-customized line to the palette. So the property is definitely there and working, it just isn't exposed. But it's not really reasonable to expect people to have to do all that. |
Interestingly, diagonal lines work for the textline thats just called 'line' in the lines palette, and you can add text in front of that. Perhaps its worth distinguishing between those two types as well... (so having 3 separate types of text lines: lines, staff text lines, & system text lines) |
Oh, that's great to know - a much better workaround! Especially since you can also add hooks etc - these really are staff text lines, they just have the allow diagonal property pre-enabled, it seems (so functionally the same as my more cumbersome workaround). |
fa1f8d3
to
525a11a
Compare
730e9ac
to
6c52b26
Compare
06d1421
to
dc5d679
Compare
134a47c
to
6a9a0b8
Compare
0fad056
to
ea527c7
Compare
Fix crash on join measures containing parts
Fix finding Docker image for ARM Linux builds
…d_playback_page getting_started_playback_page
…pad_controls Fix musescore#11128: Disable Mixer Knob and Slider Scroll
…struments-list Feat: Restoring instruments list while switching back and forth between in instruments and templates
…ation_interaction_basics Percussion panel - notation interaction basics
…model [techdebt] Clean up UndoRedoModel
Don't emit all those notifications for every command that is being undone; once at the end is enough.
Update in-repo translations from Transifex
Update in-repo translation source files
…ory-phase-2 Implement Undo/Redo naming and history
…o text-line-style
Resolves: #17757
This PR introduces style settings for the 'system text line' and 'text line' elements.
Questions: