Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line style options for text line elements #20854

Open
wants to merge 933 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
933 commits
Select commit Hold shift + click to select a range
c156efd
Format: remove trailing whitespace
cbjeukendrup Sep 20, 2024
c1694ff
Simplify things using `tee`
cbjeukendrup Sep 20, 2024
ee84507
Unify secrets/variables preconditions checks
cbjeukendrup Sep 20, 2024
311ee1f
Don't unnecessarily limit pull request runs to master branch
cbjeukendrup Sep 20, 2024
2f88539
Delete issues_delete_spam.yml
cbjeukendrup Sep 20, 2024
12475ba
Fix ccache on CI
cbjeukendrup Sep 20, 2024
8c06059
CI: replace apt with apt-get to avoid apt cli warnings
cbjeukendrup Sep 15, 2024
83fb3d8
Remove unnecessary and problematic use of `sudo`
cbjeukendrup Sep 15, 2024
1a8ded4
Attempt to correct VTest reference SHA when PR branch is outdated
cbjeukendrup Sep 21, 2024
9abaa56
VTests: Correct reference SHA for push events
cbjeukendrup Sep 21, 2024
182c8c0
Remove unnecessary fetch-depth and submodule init
cbjeukendrup Sep 21, 2024
4662ac8
Merge pull request #24784 from rpatters1/rpatters1/keyboard-switch-co…
cbjeukendrup Oct 4, 2024
fc8445e
Merge pull request #24211 from XiaoMigros/palette-drag
cbjeukendrup Oct 4, 2024
f63f28c
Fix name of the `latest` symlink for the portable Windows build
cbjeukendrup Oct 4, 2024
a6fd11e
Fix moc warnings
cbjeukendrup Oct 3, 2024
c3d5af9
Fix QML runtime warnings
cbjeukendrup Oct 3, 2024
1b9f9b1
Don't use deprecated `Q_OS_OSX` macro
cbjeukendrup Oct 4, 2024
81c2185
Remove unused variables/members/functions/parameters
cbjeukendrup Oct 4, 2024
a27f0b9
Fix clazy warnings
cbjeukendrup Oct 5, 2024
a696e33
#24908: Reworked the file corruption warning dialog
krasko78 Oct 5, 2024
5890de8
Merge pull request #24847 from cbjeukendrup/ci_cleanup
cbjeukendrup Oct 5, 2024
64add24
#24908: Gave the save buttons a role so all buttons are laid out in t…
krasko78 Oct 5, 2024
b6cfbab
Fix and simplify VTests
cbjeukendrup Oct 5, 2024
e10f78c
Merge pull request #25053 from cbjeukendrup/fix_vtest
cbjeukendrup Oct 5, 2024
8832e31
Update in-repo translations from Transifex
shoogle Oct 6, 2024
c8e7557
Run `lupdate` with arguments `-no-obsolete`
shoogle Oct 6, 2024
8f8e4a8
Merge pull request #25062 from musescore/ci_tx_pull_master
cbjeukendrup Oct 6, 2024
d7d20b0
Merge pull request #25063 from musescore/ci_lupdate_master
cbjeukendrup Oct 6, 2024
0d46478
#24908: Added the ability for devs/qa to corrupt only the original fi…
krasko78 Oct 6, 2024
b9759e0
#24908: Minor improvements
krasko78 Oct 7, 2024
81c739b
only apply color to rests
rettinghaus Oct 7, 2024
c774312
Fix crash on hidden stave grace notes
mike-spa Oct 7, 2024
392c8c0
Merge pull request #25049 from cbjeukendrup/warnings
cbjeukendrup Oct 7, 2024
e373089
Merge pull request #25067 from mike-spa/fixCrashOnGraceNotes
RomanPudashkin Oct 8, 2024
ca3daa9
fixed #24608: Revert "Fix #22273: don't startEditElement if it's alre…
Eism Oct 7, 2024
48a9dc2
fixed #22273: not for text elements
Eism Oct 7, 2024
151d32a
simplified test score and added hairpin and dynamic
Eism Oct 8, 2024
180401e
added tests
Eism Oct 8, 2024
20c8815
Name MusicXML types and methods consistently
miiizen Oct 4, 2024
45bd1aa
Name MusicXML files consistently
miiizen Oct 4, 2024
1c8f576
Name MusicXml types and methods consistently
miiizen Oct 4, 2024
f13a0da
Merge pull request #24818 from miiizen/27486-trem-up
miiizen Oct 8, 2024
7598a14
Refactor nightly builds
cbjeukendrup Oct 7, 2024
cc1c9b1
ARM Linux: Fix run_lupdate step
cbjeukendrup Oct 8, 2024
eb1dee3
ARM Linux: fix qt-chooser error in run_lupdate step
cbjeukendrup Oct 8, 2024
7694dc2
Don't run backend nightly builds for forks
cbjeukendrup Oct 8, 2024
259435a
build_all.yml: Display build type in run name
cbjeukendrup Oct 8, 2024
72d35b1
Added more keys where shift should not be removed
shubham-shinde-442 Sep 28, 2024
ad83952
More capitalisation corrections of "MusicXML" in natural language
cbjeukendrup Oct 8, 2024
04a2fbb
Merge pull request #25075 from cbjeukendrup/refactor_nightlies
cbjeukendrup Oct 8, 2024
a327063
Move Diagnostics menu and re-arrange Help menu
cbjeukendrup Oct 4, 2024
79c7d77
Merge pull request #25037 from miiizen/xml-rename
miiizen Oct 8, 2024
31640a9
Merge pull request #25047 from cbjeukendrup/diagnostics_menu
cbjeukendrup Oct 9, 2024
c806989
macOS keyboard shortcuts: fix problems with Ctrl vs Cmd
cbjeukendrup Oct 9, 2024
28755b7
Merge pull request #25065 from rettinghaus/mei/fix_space
cbjeukendrup Oct 9, 2024
8afb0f6
[techdebt] Clean up UndoRedoModel
cbjeukendrup Sep 7, 2024
77ab869
Merge pull request #25076 from Eism/textboxes_resizing_fix
Eism Oct 9, 2024
5a0d77c
Fix typo, follow up to #23473
Jojo-Schmitz Aug 14, 2024
531d66c
Use Spatium for user stem length
mathesoncalum Oct 9, 2024
f75e633
Fix mtests
Jojo-Schmitz Aug 14, 2024
78371bc
only apply color to rests
rettinghaus Oct 9, 2024
cb45b1b
Merge pull request #24914 from miiizen/24330-repeats-size
mike-spa Oct 9, 2024
6918bd4
Merge pull request #24893 from miiizen/24812-tempo-mmr
mike-spa Oct 9, 2024
efe786d
Merge pull request #25105 from rettinghaus/mei/fix_space
cbjeukendrup Oct 9, 2024
e498f57
Merge pull request #25093 from cbjeukendrup/mac_shortcuts_cmd_ctrl_fix
DmitryArefiev Oct 9, 2024
68ee939
Merge pull request #24993 from miiizen/remove-noteline
mike-spa Oct 9, 2024
ba0d4d2
Merge pull request #24036 from Jojo-Schmitz/spatium
cbjeukendrup Oct 9, 2024
e8f574d
#24536 ensure playback position rewinds to start reliably when end of…
wizofaus Sep 8, 2024
9afba26
Fix #7819 - adjustment to previous page-clipping fix
wizofaus Sep 23, 2024
80ecffe
Fix #7189 - remove check as per PR comment
wizofaus Oct 9, 2024
a8cb5f4
Merge pull request #23093 from wizofaus/fix_slur_home_key
Eism Oct 10, 2024
b6994c1
Merge pull request #25023 from miiizen/select-crash
mike-spa Oct 10, 2024
85e761c
Merge pull request #24230 from XiaoMigros/glissando-anchors
mike-spa Oct 10, 2024
50789f6
Remove focus after accepted or escaped signals to allow submit or rej…
kryksyh Sep 24, 2024
611f168
added image and actions to musesound update spec
igorkorsukov Sep 30, 2024
81aee9b
updated muse_sounds_promo image
igorkorsukov Oct 1, 2024
e015f8c
Merge pull request #25113 from wizofaus/fix_no_rewind_on_playback_end
RomanPudashkin Oct 10, 2024
eef8937
Fix MSVC compiler warnings
Jojo-Schmitz Sep 12, 2024
86885ce
Fix MSVC compiler warning
Jojo-Schmitz Sep 27, 2024
df36376
Merge pull request #25102 from mathesoncalum/25004-stem_length_smalls…
mathesoncalum Oct 10, 2024
05934b3
Merge pull request #22135 from wizofaus/clip_page_render_refix
cbjeukendrup Oct 10, 2024
c15715f
Fix custom shortcuts on macOS
cbjeukendrup Oct 10, 2024
135e805
musesampler: added the ability to enable the legacy audition mode
RomanPudashkin Oct 11, 2024
c6f4035
more useful logs
RomanPudashkin Sep 17, 2024
00fdbbf
Percussion panel - expanded pad UX/interactions
mathesoncalum Oct 11, 2024
0eadcb5
Fix 2nd Trumpet's/Horn's name in templates
Jojo-Schmitz Oct 11, 2024
0dcbc14
Merge pull request #25131 from Jojo-Schmitz/templates
cbjeukendrup Oct 11, 2024
0c45d97
Merge pull request #24672 from Jojo-Schmitz/compiler-warnings
cbjeukendrup Oct 11, 2024
81a6126
Disable concert pitch in chamber music template
AxelMatstoms Oct 12, 2024
572bd6d
Update in-repo translations from Transifex
shoogle Oct 13, 2024
fe1055b
Run `lupdate` with arguments `-no-obsolete`
shoogle Oct 13, 2024
2119e50
Merge pull request #25142 from musescore/ci_tx_pull_master
cbjeukendrup Oct 13, 2024
30b091a
Correct some translation contexts
cbjeukendrup Oct 13, 2024
7658ab1
Merge pull request #25143 from musescore/ci_lupdate_master
cbjeukendrup Oct 13, 2024
9f1c81e
Split MusicXML into import/export/shared folders
miiizen Oct 8, 2024
80d0c1d
Combine importxml.cpp and importmusicxml.cpp
miiizen Oct 8, 2024
fd82656
Move XML functionality to the namespace mu::iex::musicxml
miiizen Oct 8, 2024
bba4824
Remove use of using namespace in headers
miiizen Oct 9, 2024
5da45cf
Merge pull request #25089 from miiizen/xml-refactor-3
cbjeukendrup Oct 13, 2024
c5bdf66
Fix typo: parce -> parse
cbjeukendrup Oct 11, 2024
b627ec0
engraving_tests: don't unnecessarily mess with actual clipboard
cbjeukendrup Oct 11, 2024
8d76b03
Don't use QApplication when one of its superclasses is enough
cbjeukendrup Oct 11, 2024
10cab67
Don't expose QQuickP…m to all modules via `iuiengine.h`
cbjeukendrup Oct 11, 2024
ae5784e
Don't include <QtQml>
cbjeukendrup Oct 11, 2024
2fa8dd9
Fix includes for non-unity without pch, and use iwyu
cbjeukendrup Dec 13, 2021
888ee42
Apply some more IWYU suggestions
cbjeukendrup Oct 4, 2024
eb7daef
Update PCH - raw from iwyustat
cbjeukendrup Oct 13, 2024
770438e
Update PCH - use canonical names, trim a bit, add missing
cbjeukendrup Oct 13, 2024
99973bf
enabled sending name change for linux too
Eism Oct 8, 2024
3e77d70
Merge pull request #25120 from mathesoncalum/percussions_extended_pad_ux
RomanPudashkin Oct 14, 2024
8f0e3c9
Merge pull request #25083 from Eism/accessibility_edit_shortcuts_fix
Eism Oct 14, 2024
8694821
fix #24769
RomanPudashkin Sep 17, 2024
0acef51
Merge pull request #25146 from cbjeukendrup/qt68_prep/includes
cbjeukendrup Oct 14, 2024
ce3cbc3
Fix weird anchors mid-measure behaviour
mike-spa Oct 7, 2024
e42ac15
Use getProperty(Pid::VISIBLE) instead of visible()
mike-spa Oct 7, 2024
4679678
Merge pull request #25152 from RomanPudashkin/playback_cursor_publish…
RomanPudashkin Oct 14, 2024
b775bbd
Merge pull request #25149 from RomanPudashkin/audio_diagnostics
RomanPudashkin Oct 14, 2024
fcd3b58
CMake: use `add_compile_definitions` instead of `add_definitions`
cbjeukendrup Oct 7, 2024
483d851
Simplify compiler options setup
cbjeukendrup Oct 7, 2024
50d092e
Fix Cubase XML chord symbol import
Jojo-Schmitz Sep 29, 2024
18e9cc4
Use `trimmed()` where needed
Jojo-Schmitz Sep 29, 2024
e080dc5
Avoid double negations
cbjeukendrup Oct 14, 2024
2ab96ab
Merge pull request #25066 from mike-spa/tiesOverSystem
cbjeukendrup Oct 14, 2024
961c581
Merge pull request #22258 from wizofaus/fix_measure_properties_crash
RomanPudashkin Oct 14, 2024
fab5093
Merge pull request #25157 from cbjeukendrup/cleanup_compile_options
cbjeukendrup Oct 14, 2024
b03599e
Merge pull request #25126 from cbjeukendrup/macos_shortcuts_fix
RomanPudashkin Oct 14, 2024
9f1ca78
Fix GH#24553: MusicXML: A title like "Jazz Piece No. 5" get interpret…
Jojo-Schmitz Sep 8, 2024
a6514af
Changes after code review
Jojo-Schmitz Sep 18, 2024
7d293af
#24908: Further tweaks
krasko78 Oct 14, 2024
5fb4ca4
#24908: Fixing the code style violations
krasko78 Oct 14, 2024
559bfc2
Ensure newly added instruments are muted in excerpts
mathesoncalum Oct 15, 2024
c1f39cd
Merge pull request #24967 from Jojo-Schmitz/cubase-chord-symbol-import
cbjeukendrup Oct 15, 2024
074eeaf
manually calculation of children width
Eism Oct 15, 2024
cb2cee5
Merge pull request #25021 from mathesoncalum/24985-new_part_muting
RomanPudashkin Oct 15, 2024
a2bc250
Added Disable Backup Option
shubham-shinde-442 Oct 15, 2024
7013148
Add CODE_OF_CONDUCT.md
shoogle Oct 15, 2024
8b41402
Merge pull request #25068 from mike-spa/fixWeirdAnchorsMidMeasureBeha…
mike-spa Oct 16, 2024
0d1ad5d
Percussion panel - implement drag and drop preview
mathesoncalum Oct 16, 2024
dfcfff6
layout score before calculating the height
Eism Oct 16, 2024
2d922b9
Percussion panel - during drag, only show edit outline for dragged pa…
mathesoncalum Oct 16, 2024
4f4e0fa
Add default setting for Merge matching rests in Staff properties.
rpatters1 Oct 11, 2024
8c3de16
The one change here that is not a comment is to initialize mergeMatch…
rpatters1 Oct 11, 2024
e02d6a9
add unit tests
rpatters1 Oct 12, 2024
3c9e6fb
uncrustify
rpatters1 Oct 12, 2024
7cd730d
switch Staff::mergeMatchingRests to be AutoOnOff
rpatters1 Oct 12, 2024
162b95f
uncrustify
rpatters1 Oct 12, 2024
524ae7f
Merge pull request #25183 from Eism/video_writer_hight_fix
Eism Oct 16, 2024
5fa306a
code review changes
rpatters1 Oct 16, 2024
49779eb
Merge pull request #25174 from Eism/toolbars_width_fix
DmitryArefiev Oct 16, 2024
a9a85dd
more codereview fixes
rpatters1 Oct 16, 2024
9afb976
more code review fixes
rpatters1 Oct 16, 2024
3287840
fix #23168: correctly calculate the tremolo start time and duration f…
RomanPudashkin Sep 16, 2024
456c7f4
updated the link
Eism Oct 17, 2024
a88cf98
updated the icon file
Eism Oct 17, 2024
28727f7
Fix inferring measure rests & read the measure attribute
miiizen Oct 4, 2024
2ac0683
Merge pull request #25194 from Eism/muse_score_icon_ttf_update
Eism Oct 17, 2024
1d81f31
added QT_ADD_STATEMACHINE cmake option
igorkorsukov Oct 17, 2024
dd26124
added viewing of the list of actions to diagnostic
igorkorsukov Oct 17, 2024
1159cca
Merge pull request #25040 from miiizen/25012-xmlMeasureRests
miiizen Oct 17, 2024
2209999
fix reviewed changes
shubham-shinde-442 Oct 17, 2024
20d1369
Percussion panel - only allow deletion of empty rows
mathesoncalum Oct 17, 2024
e091719
Percussion panel - go to bottom when adding a new row (and minor spac…
mathesoncalum Oct 16, 2024
6efa493
Percussion panel - visual refinements to write/preview toggle
mathesoncalum Oct 17, 2024
0cf2ba1
Merge pull request #25178 from shubham-shinde-442/disable_backup
RomanPudashkin Oct 18, 2024
24de343
Merge pull request #25134 from rpatters1/default-merge-matching-rests…
RomanPudashkin Oct 18, 2024
6f24e10
Merge pull request #25185 from mathesoncalum/percussions_ux_refinements
RomanPudashkin Oct 18, 2024
f90a0a9
Merge pull request #24555 from Jojo-Schmitz/xml-title
miiizen Oct 18, 2024
9cccd71
Reset offset when placement is changed
miiizen Oct 2, 2024
4ab4d24
Improved detection of problems with the graphics backend
igorkorsukov Oct 18, 2024
218bf19
Merge pull request #25014 from miiizen/24551-xml-offset
mike-spa Oct 18, 2024
d67ae3e
Revert "fixed #22273: not for text elements"
mike-spa Oct 18, 2024
315d546
#24908: Undid the latest changes per code review suggestion to keep t…
krasko78 Oct 18, 2024
8f9895f
#24908: Removed unused function
krasko78 Oct 19, 2024
a19c420
Fix MSVC linker warning when using Address Sanitizer
cbjeukendrup Oct 20, 2024
afb736c
Windows: prevent mysterious compile errors in debug builds
cbjeukendrup Oct 20, 2024
f0552d1
Remove redundant `target_sources` from inspector/CMakeLists
cbjeukendrup Oct 20, 2024
1f0ff9a
Remove never-existed `MODULE_USE_UNITBUILD` from inspector/CMakeLists
cbjeukendrup Oct 20, 2024
ec85ea0
Update in-repo translations from Transifex
shoogle Oct 20, 2024
530cdd0
Run `lupdate` with arguments `-no-obsolete`
shoogle Oct 20, 2024
3007410
Merge pull request #25242 from musescore/ci_tx_pull_master
cbjeukendrup Oct 20, 2024
cb01e34
Merge pull request #25243 from musescore/ci_lupdate_master
cbjeukendrup Oct 20, 2024
ccaf575
Improved palette code for playtechannotations
XiaoMigros Jul 10, 2024
3b14808
Fix crash when switching to note entry mode
mathesoncalum Oct 21, 2024
66876e7
Merge pull request #25211 from igorkorsukov/app/check_gl_4_master
RomanPudashkin Oct 21, 2024
a56f38a
MuseSound promo: added the ability to specify the name of the cancel …
igorkorsukov Oct 18, 2024
668cb97
Disable test
mike-spa Oct 21, 2024
941f80c
Add measure-based elements without range selection
XiaoMigros Oct 20, 2024
850a705
Restore previous selection on navigation with empty selection
shoogle Oct 20, 2024
3bd9d4a
Merge pull request #25235 from cbjeukendrup/windows_fix_debug_build
cbjeukendrup Oct 21, 2024
c7be765
Merge pull request #25215 from mike-spa/revertAnchorsRegression
RomanPudashkin Oct 21, 2024
5791f04
Segment-based horizontal spacing and lyrics spacing improvements
mike-spa Oct 11, 2024
12e7d80
Fix utests - 1
mike-spa Oct 16, 2024
6df0ac1
Fix utests - 2
mike-spa Oct 16, 2024
412d67e
Fix utests - 3
mike-spa Oct 16, 2024
0d91b6a
Merge pull request #25256 from mathesoncalum/25169-templates_parts_crash
RomanPudashkin Oct 21, 2024
82a31be
code review
mike-spa Oct 21, 2024
79a381a
fixed scan old plugins
igorkorsukov Oct 14, 2024
4dc75b3
Merge pull request #25099 from mike-spa/LYRICS
mike-spa Oct 21, 2024
40073cc
Merge pull request #25236 from XiaoMigros/jumpswithoutrange
mathesoncalum Oct 21, 2024
ee42c17
Fix cross-beam edge case
mike-spa Oct 17, 2024
83657fb
new vtest
mike-spa Oct 17, 2024
deda3a5
Merge pull request #25091 from AxelMatstoms/chamber-music-concert-pitch
cbjeukendrup Oct 21, 2024
566f66c
Merge pull request #23573 from XiaoMigros/playtechpalette
cbjeukendrup Oct 22, 2024
63c4574
restoring instruments list while switching back and forth between ins…
chilkaditya Oct 3, 2024
97b56f4
fixed invalid alice reference error regarding the restoring instrumen…
chilkaditya Oct 3, 2024
7939be9
Call `instrumentsOnScoreModel.load()` at the right place/time
cbjeukendrup Oct 21, 2024
fd5199a
Merge pull request #24807 from krasko78/21553-PaletteContextMenuPosit…
RomanPudashkin Oct 22, 2024
c86a795
Merge pull request #24911 from krasko78/24908-PreventCorruptedFilesOn…
RomanPudashkin Oct 22, 2024
531c502
Merge pull request #24774 from RomanPudashkin/tremolo_tied_notes_fix
RomanPudashkin Oct 22, 2024
013999c
[extensions] added the ability to add buttons to the toolbar
igorkorsukov Sep 19, 2024
acdcafc
[extensions] changed manifest spec (main -> path)
igorkorsukov Sep 20, 2024
ead6040
[extensions] added tooltip to buttons on toolbar
igorkorsukov Sep 20, 2024
772dfaa
[extensions] chnaged extensions tool bar implementation to using Styl…
igorkorsukov Sep 24, 2024
1d3d7df
[extensions] removed toolbar config
igorkorsukov Sep 26, 2024
adac8ca
Merge pull request #25197 from mike-spa/crossBeamSpacingCorrection
mike-spa Oct 22, 2024
c8c3c96
midi: calculating string for getting channel when string isn't not set
alexpavlov96 Oct 22, 2024
4cf9dfd
Merge pull request #25275 from alexpavlov96/midi_channel_string
alexpavlov96 Oct 22, 2024
0a9a204
Fix crash on join measures containing parts
miiizen Oct 21, 2024
c8759ef
Fix crash on join bars & undo
miiizen Oct 22, 2024
e091fcd
Fix crash on join bars, undo then redo
miiizen Oct 23, 2024
5a75567
added secs_t type to global
igorkorsukov Oct 23, 2024
273ebc8
Merge pull request #25264 from miiizen/25257-join-crash
RomanPudashkin Oct 23, 2024
ca1e48e
fix #25276
RomanPudashkin Oct 22, 2024
07172f7
Fix finding Docker image for ARM Linux builds
cbjeukendrup Oct 23, 2024
965d61e
Merge pull request #25287 from cbjeukendrup/fix_arm_linux_build
cbjeukendrup Oct 23, 2024
28723cf
Fix #11128: Disable Mixer Knob and Slider Scroll
samdcchurch Oct 23, 2024
04d61db
Merge pull request #25277 from RomanPudashkin/getting_started_playbac…
RomanPudashkin Oct 24, 2024
44457b7
Percussion panel - use drumset info to create pads
mathesoncalum Oct 24, 2024
4a91259
Merge pull request #25291 from samdcchurch/11128-mixer_trackpad_controls
cbjeukendrup Oct 24, 2024
0697944
Merge pull request #25019 from chilkaditya/feat/restoring-instruments…
cbjeukendrup Oct 24, 2024
a7b076e
Percussion panel - write/preview mode basics
mathesoncalum Oct 24, 2024
c95bb47
Merge pull request #25293 from mathesoncalum/percussions_notation_int…
RomanPudashkin Oct 25, 2024
902cbae
Merge pull request #24543 from cbjeukendrup/cleanup_undoredomodel
cbjeukendrup Oct 25, 2024
93e710e
Implement Undo/Redo naming and history
rpatters1 Sep 16, 2024
68058f1
fix compiler error post-rebase
rpatters1 Oct 25, 2024
b9041cc
Code review fixes
cbjeukendrup Oct 25, 2024
d794a3b
Prevent nested `startCmd` calls
cbjeukendrup Oct 25, 2024
4375008
Corrections to Undoable Actions names
cbjeukendrup Oct 25, 2024
74dfd07
Don't make non-user-facing undoable action names translatable
cbjeukendrup Oct 25, 2024
a346c51
Modernise UndoStack class
cbjeukendrup Oct 26, 2024
857cdd0
Optimise `NotationUndoStack::undoRedoToIdx`
cbjeukendrup Oct 26, 2024
c6bd48a
Clean up UndoHistoryDialog from a UI pov
cbjeukendrup Oct 26, 2024
1787194
Split UndoRedoModel into U…oToolbarModel and U…oHistoryModel
cbjeukendrup Oct 26, 2024
f88248c
Update in-repo translations from Transifex
shoogle Oct 27, 2024
de14ef1
Run `lupdate` with arguments `-no-obsolete`
shoogle Oct 27, 2024
e5eca7c
Merge pull request #25328 from musescore/ci_tx_pull_master
cbjeukendrup Oct 27, 2024
2da8058
Merge pull request #25329 from musescore/ci_lupdate_master
cbjeukendrup Oct 27, 2024
d54fd57
Merge pull request #24744 from rpatters1/rpatters1/undo-history-phase-2
cbjeukendrup Oct 27, 2024
45bfb36
line style options for text lines
XiaoMigros Jan 6, 2024
6b26518
Merge branch 'text-line-style' of github.com:XiaoMigros/MuseScore int…
XiaoMigros Oct 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 0 additions & 6 deletions .github/issue_assign_by_label_config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
corruption:
- cbjeukendrup
crash:
- RomanPudashkin
- DmitryArefiev
Expand All @@ -12,10 +10,6 @@ VST:
- matthewreadbass
playback:
- RomanPudashkin
UI:
- Eism
accessibility:
- Eism
cloud:
- shoogle
- cbjeukendrup
156 changes: 156 additions & 0 deletions .github/workflows/build_all.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
name: "Build: All"
run-name: "Build: All - ${{ inputs.build_mode }}"

on:
workflow_dispatch:
inputs:
platforms:
description: 'Platforms to build:'
default: 'backend linux_arm32 linux_arm64 linux_x64 macos windows_x64 windows_portable'
required: true
build_mode:
description: 'Build mode: devel,nightly,testing,stable'
default: 'devel'
required: true
publish:
description: 'Publish to FTP: on - publish'
default: 'off'
required: false
sentry_project:
description: 'Upload symbols and dumps to Sentry (choose a project): mu4(default for stable build), sandbox'
default: ''
required: false
workflow_call:
inputs:
platforms:
description: 'Platforms to build:'
default: 'backend linux_arm32 linux_arm64 linux_x64 macos windows_x64 windows_portable'
type: string
required: true
build_mode:
description: 'Build mode: devel,nightly,testing,stable'
default: 'devel'
type: string
required: true
publish:
description: 'Publish to FTP: on - publish'
default: 'off'
type: string
required: false
sentry_project:
description: 'Upload symbols and dumps to Sentry (choose a project): mu4(default for stable build), sandbox'
default: ''
type: string
required: false

defaults:
run:
shell: bash

jobs:

backend:
name: Backend
if: ${{ contains(inputs.platforms, 'backend') }}
uses: ./.github/workflows/build_backend.yml
secrets: inherit
with:
build_mode: ${{ inputs.build_mode }}
publish: ${{ inputs.publish }}

linux_arm:
name: Linux ARM
uses: ./.github/workflows/build_linux_arm.yml
secrets: inherit
with:
platforms: ${{ inputs.platforms }}
build_mode: ${{ inputs.build_mode }}
publish: ${{ inputs.publish }}
sentry_project: ${{ inputs.sentry_project }}

linux_x64:
name: Linux x64
if: ${{ contains(inputs.platforms, 'linux_x64') }}
uses: ./.github/workflows/build_linux.yml
secrets: inherit
with:
build_mode: ${{ inputs.build_mode }}
publish: ${{ inputs.publish }}
sentry_project: ${{ inputs.sentry_project }}

macos:
name: macOS
if: ${{ contains(inputs.platforms, 'macos') }}
uses: ./.github/workflows/build_macos.yml
secrets: inherit
with:
build_mode: ${{ inputs.build_mode }}
publish: ${{ inputs.publish }}
sentry_project: ${{ inputs.sentry_project }}

windows:
name: Windows
uses: ./.github/workflows/build_windows.yml
secrets: inherit
with:
platforms: ${{ inputs.platforms }}
build_mode: ${{ inputs.build_mode }}
publish: ${{ inputs.publish }}
sentry_project: ${{ inputs.sentry_project }}

# Dummy build for testing purposes.
dummy:
if: ${{ contains(inputs.platforms, 'dummy') }}
strategy:
fail-fast: false
matrix:
# Expose edge cases like different command versions, CRLF line endings, etc.
# Use same OS versions as used in real build workflows.
os:
- ubuntu-20.04 # linux_x64, backend
- ubuntu-22.04 # linux_arm32, linux_arm64
- macos-latest
- windows-2022 # windows_x64, windows_portable
runs-on: ${{ matrix.os }}
steps:
- name: Clone repository
uses: actions/checkout@v4
- name: Prepare dummy artifact
run: |
ARTIFACTS_DIR="build.artifacts"
echo "ARTIFACTS_DIR=${ARTIFACTS_DIR}" | tee -a "${GITHUB_ENV}"

buildscripts/ci/tools/make_build_mode_env.sh -e "${{ github.event_name }}" -m "${{ inputs.build_mode }}"
BUILD_MODE="$(<"${ARTIFACTS_DIR}/env/build_mode.env")"

case "${BUILD_MODE}" in
testing) MUSE_APP_BUILD_MODE=testing;;
stable) MUSE_APP_BUILD_MODE=release;;
*) MUSE_APP_BUILD_MODE=dev;;
esac

buildscripts/ci/tools/make_build_number.sh
BUILD_NUMBER="$(<"${ARTIFACTS_DIR}/env/build_number.env")"

buildscripts/ci/tools/make_version_env.sh "${BUILD_NUMBER}"
BUILD_VERSION="$(<"${ARTIFACTS_DIR}/env/build_version.env")"

buildscripts/ci/tools/make_branch_env.sh
BUILD_BRANCH="$(<"${ARTIFACTS_DIR}/env/build_branch.env")"

buildscripts/ci/tools/make_release_channel_env.sh -c "${MUSE_APP_BUILD_MODE}"
buildscripts/ci/tools/make_revision_env.sh "$(git rev-parse --short=7 HEAD)"

buildscripts/ci/tools/make_artifact_name_env.sh "MuseScore-Dummy-${BUILD_VERSION}-${{ matrix.os }}-${HOSTTYPE}.txt"
ARTIFACT_NAME="$(<"${ARTIFACTS_DIR}/env/artifact_name.env")"

echo "Hello, world!" >"${ARTIFACTS_DIR}/${ARTIFACT_NAME}"
buildscripts/ci/tools/checksum.sh

UPLOAD_ARTIFACT_NAME="$(tr '":<>|*?/\\’' '_' <<<"MU4_${BUILD_NUMBER}_Dummy-${{ matrix.os }}_${BUILD_BRANCH}")"
echo "UPLOAD_ARTIFACT_NAME=${UPLOAD_ARTIFACT_NAME}" | tee -a "${GITHUB_ENV}"
- name: Upload artifacts to GitHub
uses: actions/upload-artifact@v4
with:
name: ${{ env.UPLOAD_ARTIFACT_NAME }}
path: ${{ env.ARTIFACTS_DIR }}
63 changes: 40 additions & 23 deletions .github/workflows/build_backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,29 @@ on:
inputs:
build_mode:
description: 'Build mode: devel, testing, stable'
required: true
default: 'devel'
required: true
publish:
description: 'Publish: on - publish'
default: 'off'
required: false
workflow_call:
inputs:
build_mode:
description: 'Build mode: devel, nightly, testing, stable'
default: 'devel'
type: string
required: true
publish:
description: 'Publish: on - publish'
default: 'off'
type: string
required: false

jobs:
build_mu4:
backend:
runs-on: ubuntu-20.04
if: github.event_name != 'schedule' || github.repository == 'musescore/MuseScore'
steps:
- name: Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.12.1
Expand All @@ -28,57 +41,61 @@ jobs:

- name: "Configure workflow"
run: |
bash ./buildscripts/ci/tools/make_build_mode_env.sh -e ${{ github.event_name }} -m ${{ github.event.inputs.build_mode }}
bash ./buildscripts/ci/tools/make_build_mode_env.sh -e ${{ github.event_name }} -m ${{ inputs.build_mode }}
BUILD_MODE=$(cat ./build.artifacts/env/build_mode.env)

bash ./buildscripts/ci/tools/make_build_number.sh
BUILD_NUMBER=$(cat ./build.artifacts/env/build_number.env)

DO_PUBLISH='false'
if [ "${{ github.event.inputs.publish }}" = "on" ]; then DO_PUBLISH='true'; fi
if [ -z "${{ secrets.S3_KEY_CONVERTER }}" ]; then DO_PUBLISH='false'; fi
if [ -z "${{ secrets.S3_SECRET_CONVERTER }}" ]; then DO_PUBLISH='false'; fi
if [ "${{ inputs.publish }}" = "on" ]; then
DO_PUBLISH='true';
if [ -z "${{ secrets.S3_KEY_CONVERTER }}" ]; then
echo "::warning::S3_KEY_CONVERTER is empty; publishing to S3 disabled"
DO_PUBLISH='false'
fi
if [ -z "${{ secrets.S3_SECRET_CONVERTER }}" ]; then
echo "::warning::S3_SECRET_CONVERTER is empty; publishing to S3 disabled"
DO_PUBLISH='false'
fi
fi

bash ./buildscripts/ci/tools/make_version_env.sh $BUILD_NUMBER
VERSION=$(cat ./build.artifacts/env/build_version.env)
GITHUB_ARTIFACT_NAME="MuseScore-${VERSION}"

echo "github.repository: ${{ github.repository }}"
echo "BUILD_MODE=$BUILD_MODE" >> $GITHUB_ENV
echo "BUILD_MODE: $BUILD_MODE"
echo "BUILD_NUMBER=$BUILD_NUMBER" >> $GITHUB_ENV
echo "BUILD_NUMBER: $BUILD_NUMBER"
echo "DO_PUBLISH=$DO_PUBLISH" >> $GITHUB_ENV
echo "DO_PUBLISH: $DO_PUBLISH"
echo "GITHUB_ARTIFACT_NAME=$GITHUB_ARTIFACT_NAME" >> $GITHUB_ENV
echo "GITHUB_ARTIFACT_NAME: $GITHUB_ARTIFACT_NAME"
echo "BUILD_MODE=$BUILD_MODE" | tee -a $GITHUB_ENV
echo "BUILD_NUMBER=$BUILD_NUMBER" | tee -a $GITHUB_ENV
echo "DO_PUBLISH=$DO_PUBLISH" | tee -a $GITHUB_ENV
echo "GITHUB_ARTIFACT_NAME=$GITHUB_ARTIFACT_NAME" | tee -a $GITHUB_ENV

- name: Setup environment
run: |
sudo bash ./buildscripts/ci/backend/setup.sh
bash ./buildscripts/ci/backend/setup.sh

- name: Build
run: |
sudo bash ./buildscripts/ci/backend/build.sh -n ${{ env.BUILD_NUMBER }} --build_videoexport
bash ./buildscripts/ci/backend/build.sh -n ${{ env.BUILD_NUMBER }} --build_videoexport

- name: Package
run: |
sudo bash ./buildscripts/ci/backend/package.sh
bash ./buildscripts/ci/backend/package.sh

- name: Publish to S3
- name: Publish to S3
if: env.DO_PUBLISH == 'true'
run: |
sudo bash ./buildscripts/ci/backend/publish_to_s3.sh --s3_key ${{ secrets.S3_KEY_CONVERTER }} --s3_secret ${{ secrets.S3_SECRET_CONVERTER }}
bash ./buildscripts/ci/backend/publish_to_s3.sh --s3_key ${{ secrets.S3_KEY_CONVERTER }} --s3_secret ${{ secrets.S3_SECRET_CONVERTER }}

- name: Build Docker
if: env.DO_PUBLISH == 'true'
run: |
sudo bash ./buildscripts/ci/backend/build_docker.sh
bash ./buildscripts/ci/backend/build_docker.sh

- name: Publish to Registry
- name: Publish to Registry
if: env.DO_PUBLISH == 'true'
run: |
sudo bash ./buildscripts/ci/backend/publish_to_registry.sh --token ${{ secrets.PACKAGES_PAT }}
bash ./buildscripts/ci/backend/publish_to_registry.sh --token ${{ secrets.PACKAGES_PAT }}

- name: Upload artifacts on GitHub
if: ${{ always() }}
Expand Down
Loading
Loading