-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select tuplet when calling next-element prev-element actions #23082
Select tuplet when calling next-element prev-element actions #23082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! You've nearly solved the next-element
function (but not quite), and you also need to do the same in the other direction with previous-element
(Alt+Left).
From #17600 (comment):
If you go in the other direction with Alt+Left then the elements should be selected in reverse order.
2704d5b
to
2a27a41
Compare
Going back does not select them in reverse order, both directions select the tuplet first. |
@Jojo-Schmitz is right, when going backwards it's not in reverse order. Here's what we want to see:
|
f91f1be
to
c684e78
Compare
Hii! Sorry for taking so much time making the changes, PR is ready to be reviewed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry, i was trying to remove the change request)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality is there, thanks! Just a couple of comments about the code.
Hello! Thank you for the review ! I have edited the code according to the comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please fix the build and then squash all your commits into one.
541ee6a
to
3538d12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks!
Resolves: #17600
Select tuplet when calling action next-element and prev-element