-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo, follow up to #23473 #24036
Conversation
Unfortunately now 545 occurences in unit test files would need to get amended, any clever idea how to not have to do it manually? Sledghammer approach: |
Maybe something with a regular expression, to replace |
Hmm, let's see whether |
446cf53
to
51ffd39
Compare
Better: |
Any news about this? Should it go into 4.4? I suspect a lot of bit rot on this one the longer it sits unmerged, i.e. more failing unit tests... |
No, it shouldn't go into 4.4. We'll have to wait for @mike-spa to review it first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
deb14c1
to
7c45ddb
Compare
Rebased (to fix merge conflict) and refreshed (to include scores added since) |
by running `for f in $(find . -name '*.mscx' | xargs grep -l 'museScore version="4.40"'); do sed -i 's/Spatium>/spatium>/g' $f; done`, i.e. replacing "Spatium>" with "spatium>" in all 4.4 mscx files
How far back is MuseScore accepting I only ask because I've written a |
Since 4.4.0, some 3 months ago |
We changed the style tag "Spatium" into "spatium" in #23473, but still write "Spatium" hard coded into the style files, this PR fixes that. On reading we already read both, so no extra action needed.