-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Qt 6.8 #25016
Draft
cbjeukendrup
wants to merge
18
commits into
musescore:master
Choose a base branch
from
cbjeukendrup:qt6/next/6.8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Switch to Qt 6.8 #25016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
force-pushed
the
qt6/next/6.8
branch
21 times, most recently
from
October 5, 2024 22:05
e4221e5
to
1f7cbde
Compare
Status update:
Next thing I'm going to try is what happens when we switch to DirectWrite. |
cbjeukendrup
force-pushed
the
qt6/next/6.8
branch
3 times, most recently
from
October 8, 2024 14:23
74d7ce5
to
a1c8d43
Compare
Closed
cbjeukendrup
force-pushed
the
qt6/next/6.8
branch
from
October 14, 2024 09:35
a1c8d43
to
02978af
Compare
cbjeukendrup
force-pushed
the
qt6/next/6.8
branch
2 times, most recently
from
October 14, 2024 19:37
8341aad
to
e05fe4a
Compare
cbjeukendrup
force-pushed
the
qt6/next/6.8
branch
3 times, most recently
from
October 29, 2024 02:19
2da48b1
to
f245ae6
Compare
cbjeukendrup
force-pushed
the
qt6/next/6.8
branch
2 times, most recently
from
November 5, 2024 21:29
daca8a5
to
948112b
Compare
cbjeukendrup
force-pushed
the
qt6/next/6.8
branch
from
November 23, 2024 14:31
948112b
to
4ca851d
Compare
cbjeukendrup
force-pushed
the
qt6/next/6.8
branch
from
December 12, 2024 11:05
4ca851d
to
7d6ae9e
Compare
which is required for Qt 6.5.0
It was deprecated in Qt 6.4. Basically, just need to specify `globalPos`
It was deprecated during the Qt 6.8 beta phase, but it looks like this deprecation has been postponed to Qt 6.9. Anyway, there is now a better alternative called `checkStateChanged`, that uses `Qt::CheckState` instead of `int`.
To be sure that we're using a new-enough version for all Qt 6.8 features
I verified that they don't do anything scary, so let's use them, to keep our code in line with the documentation, and to be sure that we're ready to use modern Qt/CMake possibilities.
When an error occurs while creating a component, don't cause even more errors by reading from `null` at `dialogObj.object.objectId`
cbjeukendrup
force-pushed
the
qt6/next/6.8
branch
from
December 24, 2024 00:08
7d6ae9e
to
38f29a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #11244
Resolves: #12467 (probably, according to comment there)
Resolves: #22416
Resolves: #23505
Resolves: #23970
Resolves: #24206
Resolves: #24232
Resolves: #24579
Resolves: #24613
Resolves: #24667
Resolves: #24716
Resolves: #25300
Resolves: #25307
Resolves: #25379