Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Qt 6.8 #25016

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/build_backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ jobs:
BUILD_NUMBER=$(cat ./build.artifacts/env/build_number.env)

DO_PUBLISH='false'
if [ "${{ inputs.publish }}" = "on" ]; then
if [ "${{ inputs.publish }}" = "on" ]; then
DO_PUBLISH='true';
if [ -z "${{ secrets.S3_KEY_CONVERTER }}" ]; then
if [ -z "${{ secrets.S3_KEY_CONVERTER }}" ]; then
echo "::warning::S3_KEY_CONVERTER is empty; publishing to S3 disabled"
DO_PUBLISH='false'
fi
Expand All @@ -74,6 +74,16 @@ jobs:
echo "VERSION_MAJOR_MINOR=$VERSION_MAJOR_MINOR" | tee -a $GITHUB_ENV
echo "GITHUB_ARTIFACT_NAME=$GITHUB_ARTIFACT_NAME" | tee -a $GITHUB_ENV

- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'linux'
target: 'desktop'
arch: 'linux_gcc_64'
modules: 'qt5compat qtnetworkauth qtscxml qtshadertools qtwebsockets'

- name: Setup environment
run: |
bash ./buildscripts/ci/backend/setup.sh
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/build_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,25 @@ jobs:
sudo apt-get update && sudo apt-get install -y ccache
bash ./buildscripts/ci/tools/setup_ccache_config.sh

- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'linux'
target: 'desktop'
arch: 'linux_gcc_64'
modules: 'qt5compat qtnetworkauth qtscxml qtshadertools qtwebsockets'
- name: Setup environment
run: |
bash ./buildscripts/ci/linux/setup.sh

- name: Generate _en.ts files
env:
LUPDATE_ARGS: ""
POSTPROCESS_ARGS: ${{ env.DO_PLACEHOLDER_TRANSLATIONS == 'true' && '--generate-placeholder-translations' || '' }}
run: |
bash ./buildscripts/ci/translation/run_lupdate.sh
bash ./tools/translations/run_lupdate.sh
- name: Update .ts files
if: env.DO_UPDATE_TS == 'true'
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build_linux_arm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobs:
# LUPDATE_ARGS: ""
# POSTPROCESS_ARGS: ${{ env.DO_PLACEHOLDER_TRANSLATIONS == 'true' && '--generate-placeholder-translations' || '' }}
# run: |
# bash ./buildscripts/ci/translation/run_lupdate.sh
# bash ./tools/translations/run_lupdate.sh
- name: Update .ts files
if: env.DO_UPDATE_TS == 'true'
run: |
Expand All @@ -160,7 +160,7 @@ jobs:
cd /MuseScore && \
export QT_SELECT=qt6 && \
bash /MuseScore/buildscripts/ci/linux/setup-arm.sh --arch armv7l && \
bash /MuseScore/buildscripts/ci/translation/run_lupdate.sh && \
bash /MuseScore/tools/translations/run_lupdate.sh && \
bash /MuseScore/buildscripts/ci/linux/build.sh -n ${{ env.BUILD_NUMBER }} --crash_log_url $C_URL --arch armv7l && \
bash /MuseScore/buildscripts/ci/linux/package.sh --arch armv7l && \
bash /MuseScore/buildscripts/ci/tools/checksum.sh \
Expand Down Expand Up @@ -269,7 +269,7 @@ jobs:
# LUPDATE_ARGS: ""
# POSTPROCESS_ARGS: ${{ env.DO_PLACEHOLDER_TRANSLATIONS == 'true' && '--generate-placeholder-translations' || '' }}
# run: |
# bash ./buildscripts/ci/translation/run_lupdate.sh
# bash ./tools/translations/run_lupdate.sh
- name: Update .ts files
if: env.DO_UPDATE_TS == 'true'
run: |
Expand All @@ -289,7 +289,7 @@ jobs:
cd /MuseScore && \
export QT_SELECT=qt6 && \
bash /MuseScore/buildscripts/ci/linux/setup-arm.sh --arch aarch64 && \
bash /MuseScore/buildscripts/ci/translation/run_lupdate.sh && \
bash /MuseScore/tools/translations/run_lupdate.sh && \
bash /MuseScore/buildscripts/ci/linux/build.sh -n ${{ env.BUILD_NUMBER }} --crash_log_url $C_URL --arch aarch64 && \
bash /MuseScore/buildscripts/ci/linux/package.sh --arch aarch64 && \
bash /MuseScore/buildscripts/ci/tools/checksum.sh \
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/build_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,25 @@ jobs:
brew install ccache
bash ./buildscripts/ci/tools/setup_ccache_config.sh

- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'mac'
target: 'desktop'
arch: 'clang_64'
modules: 'qt5compat qtnetworkauth qtscxml qtshadertools qtwebsockets'
- name: Setup environment
run: |
bash ./buildscripts/ci/macos/setup.sh

- name: Generate _en.ts files
env:
LUPDATE_ARGS: ""
POSTPROCESS_ARGS: "--warn-only ${{ env.DO_PLACEHOLDER_TRANSLATIONS == 'true' && '--generate-placeholder-translations' || '' }}"
run: |
bash ./buildscripts/ci/translation/run_lupdate.sh
bash ./tools/translations/run_lupdate.sh
- name: Update .ts files
if: env.DO_UPDATE_TS == 'true'
run: |
Expand Down
32 changes: 22 additions & 10 deletions .github/workflows/build_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,21 +132,27 @@ jobs:
echo "DO_PUBLISH=$DO_PUBLISH" | tee -a $GITHUB_ENV
echo "UPLOAD_ARTIFACT_NAME=$UPLOAD_ARTIFACT_NAME" | tee -a $GITHUB_ENV

- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'windows'
target: 'desktop'
arch: 'win64_msvc2022_64'
modules: 'qt5compat qtnetworkauth qtscxml qtshadertools qtwebsockets'
- name: Setup environment
run: |
buildscripts\ci\windows\setup.bat
- name: Make environment file
shell: bash
run: |
bash ./buildscripts/ci/windows/make_environment.sh

- name: Generate _en.ts files
shell: bash
env:
LUPDATE_ARGS: ""
POSTPROCESS_ARGS: "--warn-only ${{ env.DO_PLACEHOLDER_TRANSLATIONS == 'true' && '--generate-placeholder-translations' || '' }}"
POSTPROCESS_LAUNCHER: "python3 -X utf8"
run: |
bash ./buildscripts/ci/translation/run_lupdate.sh
bash ./tools/translations/run_lupdate.sh
- name: Update .ts files
if: env.DO_UPDATE_TS == 'true'
shell: bash
Expand Down Expand Up @@ -253,21 +259,27 @@ jobs:
echo "DO_PUBLISH=$DO_PUBLISH" | tee -a $GITHUB_ENV
echo "UPLOAD_ARTIFACT_NAME=$UPLOAD_ARTIFACT_NAME" | tee -a $GITHUB_ENV

- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'windows'
target: 'desktop'
arch: 'win64_msvc2022_64'
modules: 'qt5compat qtnetworkauth qtscxml qtshadertools qtwebsockets'
- name: Setup environment
run: |
buildscripts\ci\windows\setup.bat --portable ON
- name: Make environment file
shell: bash
run: |
bash ./buildscripts/ci/windows/make_environment.sh

- name: Generate _en.ts files
shell: bash
env:
LUPDATE_ARGS: ""
POSTPROCESS_ARGS: "--warn-only ${{ env.DO_PLACEHOLDER_TRANSLATIONS == 'true' && '--generate-placeholder-translations' || '' }}"
POSTPROCESS_LAUNCHER: "python3 -X utf8"
run: |
bash ./buildscripts/ci/translation/run_lupdate.sh
bash ./tools/translations/run_lupdate.sh
- name: Update .ts files
if: env.DO_UPDATE_TS == 'true'
shell: bash
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/check_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,19 @@ jobs:
sudo apt-get update && sudo apt-get install -y ccache
bash ./buildscripts/ci/tools/setup_ccache_config.sh

- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'linux'
target: 'desktop'
arch: 'linux_gcc_64'
modules: 'qt5compat qtnetworkauth qtscxml qtshadertools qtwebsockets'
- name: Setup environment
run: |
bash ./buildscripts/ci/linux/setup.sh

- name: Build
run: |
mkdir -p build.artifacts/env
Expand Down
26 changes: 23 additions & 3 deletions .github/workflows/check_visual_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ jobs:
if: github.event_name == 'push'
run: |
REFERENCE_SHA=${{ github.event.before }}
if [[ -z "$REFERENCE_SHA" || "$REFERENCE_SHA" == 0000000000000000000000000000000000000000 ]]; then
DO_RUN='false'
else
if [[ -z "$REFERENCE_SHA" || "$REFERENCE_SHA" == 0000000000000000000000000000000000000000 ]]; then
DO_RUN='false'
else
DO_RUN='true'
fi
echo "REFERENCE_SHA=$REFERENCE_SHA" >> $GITHUB_ENV
Expand Down Expand Up @@ -79,9 +79,19 @@ jobs:
sudo apt-get update && sudo apt-get install -y ccache
bash ./buildscripts/ci/tools/setup_ccache_config.sh

- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'linux'
target: 'desktop'
arch: 'linux_gcc_64'
modules: 'qt5compat qtnetworkauth qtscxml qtshadertools qtwebsockets'
- name: Setup environment
run: |
bash ./buildscripts/ci/linux/setup.sh

- name: Build and Pack
run: |
bash ./buildscripts/ci/vtests/build_and_pack.sh
Expand Down Expand Up @@ -117,9 +127,19 @@ jobs:
sudo apt-get update && sudo apt-get install -y ccache
bash ./buildscripts/ci/tools/setup_ccache_config.sh

- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'linux'
target: 'desktop'
arch: 'linux_gcc_64'
modules: 'qt5compat qtnetworkauth qtscxml qtshadertools qtwebsockets'
- name: Setup environment
run: |
bash ./buildscripts/ci/linux/setup.sh

- name: Build and Pack
run: |
bash ./buildscripts/ci/vtests/build_and_pack.sh
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/translate_lupdate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,19 @@ jobs:

echo "LUPDATE_ARGS=$LUPDATE_ARGS" | tee -a $GITHUB_ENV

- name: Setup environment
run: |
bash ./buildscripts/ci/translation/qt_install.sh
- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'linux'
target: 'desktop'
arch: 'linux_gcc_64'
archives: 'qttools'

- name: Run lupdate
run: |
bash ./buildscripts/ci/translation/run_lupdate.sh
bash ./tools/translations/run_lupdate.sh

- name: Create Pull Request
uses: peter-evans/create-pull-request@v7
Expand Down
13 changes: 11 additions & 2 deletions .github/workflows/translate_tx_pull_to_s3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,20 @@ jobs:
run: |
bash ./buildscripts/ci/translation/tx_install.sh -t ${{ secrets.TRANSIFEX_API_TOKEN }} -s linux

- name: Install Qt for lrelease
if: env.DO_PUSH_TO_S3 == 'true'
uses: jurplel/install-qt-action@v4
with:
aqtversion: '==3.1.*'
version: '6.8.0'
host: 'linux'
target: 'desktop'
arch: 'linux_gcc_64'
archives: 'qttools'

- name: Setup environment for pushing to S3
if: env.DO_PUSH_TO_S3 == 'true'
run: |
# lrelease
bash ./buildscripts/ci/translation/qt_install.sh
bash ./buildscripts/ci/tools/s3_install.sh --s3_key ${{ secrets.S3_KEY }} --s3_secret ${{ secrets.S3_SECRET }}

bash ./buildscripts/ci/tools/make_build_number.sh
Expand Down
5 changes: 2 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
# along with this program. If not, see <https://www.gnu.org/licenses/>.

cmake_minimum_required(VERSION 3.16)
cmake_minimum_required(VERSION 3.21.1) # Min. required by Qt 6.8

project(MuseScore LANGUAGES C CXX)

Expand Down Expand Up @@ -151,7 +151,6 @@ if (MUE_COMPILE_MACOS_PRECOMPILED_DEPS_PATH)
set(MUE_COMPILE_USE_SYSTEM_OPUS ON)
endif()

set(QT_MIN_VERSION "6.2.4")
set(QT_ADD_STATEMACHINE ON)
if (MUSE_MODULE_NETWORK_WEBSOCKET)
set(QT_ADD_WEBSOCKET ON)
Expand Down
2 changes: 1 addition & 1 deletion buildscripts/ci/linux/local/workflow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ fi

# - name: Generate _en.ts files
# run: |
bash ./buildscripts/ci/translation/run_lupdate.sh
bash ./tools/translations/run_lupdate.sh

# - name: Update .ts files
# if: env.DO_UPDATE_TS == 'true'
Expand Down
Loading
Loading