Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keysigs on section break #25260

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Oct 21, 2024

Resolves: #25168

  • On section break add key signatures, and mark them "forSectionBreak".
  • When removing section break, remove "for section break" signatures.
  • If signature already there, it is preserved (not marked "for section break" and not removed on section break deletion.
  • New signatures added to section break are also not marked as "for section break", so not removed on section break deletion.
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@sammik sammik force-pushed the section-break-keysig branch from c7ec3da to 02df82c Compare December 25, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key signatures after section break are not transposed by transpose dialog
2 participants