-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add courtesy keysig to last measure even if it is followed by frame #25420
Merged
mike-spa
merged 2 commits into
musescore:master
from
sammik:courtesy-keysig-before-frame
Dec 17, 2024
Merged
add courtesy keysig to last measure even if it is followed by frame #25420
mike-spa
merged 2 commits into
musescore:master
from
sammik:courtesy-keysig-before-frame
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammik
force-pushed
the
courtesy-keysig-before-frame
branch
from
November 4, 2024 15:18
a9e5225
to
04f5687
Compare
oktophonie
approved these changes
Nov 8, 2024
mike-spa
approved these changes
Dec 17, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 17, 2024
I don't think courtesy key sigs should show in that case, just like courtesy clefs and courtesy time sigs Changing to if (ctx.state().prevMeasure() && ! ctx.state().prevMeasure()->sectionBreak()) {
MeasureLayout::createEndBarLines(lm, true, ctx);
} fixes that, I'll PR this, see #25865 |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 17, 2024
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 17, 2024
…section break Follow up to musescore#25420
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 17, 2024
…section break Follow up to musescore#25420
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 17, 2024
Thank You, I missed this. |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 22, 2024
…section break Follow up to musescore#25420
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 22, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 25, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22256
Resolves: #19759
MeasureLayout::createEndBarLines(measure, **false**, ctx);
, which setsElementFlag::KEYSIG
of measurebase tofalse
, so before adding trailer, we need to re-createEndBarLines
with truthyisLastMeasureInSystem
value