Fix #23090: Added style option to use expression font for dynamics #25750
+869
−528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HemantAntony
force-pushed
the
23090-option_to_use_expression_font_dynamics
branch
5 times, most recently
from
59ae355 to
a69a6f0
Compare
shoogle
reviewed
Dec 20, 2024
This changes the way TextFragments are stored in TextBlock from a list of TextFragment to a list of TextFragment shared pointers. This is necessary because the new DynamicFragment cannot be stored in the earlier list because of object slicing. tmp
This changes the way to access text in TextFragment from a variable to a getter/setter model. This is necessary to handle when DynamicFragment text is changed. Update textbase.h
HemantAntony
force-pushed
the
23090-option_to_use_expression_font_dynamics
branch
from
a69a6f0 to
dd49c24
Compare
|
@HemantAntony Thanks for working on this! Small request: the height of the dropdown next to "Choose font" is too short (24px). It should be 30px to match the standard dropdowns we use everywhere else |
…namics This commit introduces a new class DynamicFragment which inherits the TextFragment class. This is used to handle the changes for Dynamics.
HemantAntony
force-pushed
the
23090-option_to_use_expression_font_dynamics
branch
from
dd49c24 to
a784154
Compare
|
@avvvvve I have updated the PR. Does it look good now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23090
Within Format > Style:
New style parameter:
dynamicsUseExpressionFont(accessibility feature)When enabled, dynamic symbols (p, mf, etc.) are rendered in the same font as surrounding text.
The option can be enabled or disabled at any time to convert existing scores to and from the accessible rendering.
Editing dynamics
While editing, dynamics always use the traditional rendering so that users know which characters are "special".
@shoogle