Let Ring playback #25864
Draft
Let Ring playback #25864
+461
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathesoncalum
approved these changes
Dec 17, 2024
rettinghaus
approved these changes
Dec 17, 2024
RomanPudashkin
force-pushed
the
muse_sounds_let_ring_playback
branch
from
c93a6aa to
2b50f32
Compare
RomanPudashkin
force-pushed
the
muse_sounds_let_ring_playback
branch
from
bb56ceb to
78eabbc
Compare
| appendControlSwitch(destination, noteEvent, PEDAL_CC_SUPPORTED_TYPES, midi::SUSTAIN_PEDAL_CONTROLLER); | ||
| appendPitchBend(destination, noteEvent, BEND_SUPPORTED_TYPES, channelIdx); | ||
| for (const auto& pair : noteEvent.expressionCtx().articulations) { | ||
| if (muse::contains(PEDAL_CC_SUPPORTED_TYPES, pair.first)) { |
There was a problem hiding this comment.
Apologies if it's a silly question, but is it possible for this conditional to execute more than once throughout the loop? If so, is it OK to call appendControlSwitch more than once for a given noteEvent?
There was a problem hiding this comment.
It should be ok to call appendControlSwitch more than once. In practice, that won't happen simply because we only use it for the pedal right now (and each noteEvent will have only 1 pedal articulation)
mathesoncalum
approved these changes
Dec 20, 2024
|
Tested #20993 on Win10 - FIXED for VST and MS Basic Still occurs with MuseSounds (it will be fixed later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #20993 (including MS Basic & VST)