No courtesy keysig to last measure if it is followed by frame with a section break #25865
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Jojo-Schmitz
force-pushed
the
courtesy-keysig-before-frame
branch
from
fffa4ef to
574b4b9
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 17, 2024
…section break Backport of musescore#25865
sammik
reviewed
Dec 18, 2024
There was a problem hiding this comment.
I am not sure, if this is best place for souch test.
I think, if section break test "dont create coutesy, if measure is section break" is already in code somewhere , we just should update codnition to "dont create courtesy, if measure is last real measure in system with section break"
|
Any better place? |
This comment was marked as outdated.
This comment was marked as outdated.
I would say this one: with change of What do You think? |
…section break Follow up to musescore#25420
Jojo-Schmitz
force-pushed
the
courtesy-keysig-before-frame
branch
from
574b4b9 to
a8c54ca
Compare
|
Looks good to me, thanks. Changed, pushed, attributed... |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 22, 2024
…section break Backport of musescore#25865
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 25, 2024
…section break Backport of musescore#25865
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 25, 2024
…section break Backport of musescore#25865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #25420
Resolves: #22256
Resolves: #19759