Feat: Add DSP pipeline details to stream information #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximmaxim345
changed the title
|
models package has been bumped to unblock this PR |
maximmaxim345
force-pushed
the
feat/dsp-streamdetails
branch
from
5bbedd8 to
5b57c2b
Compare
marcelveldt
reviewed
Jan 16, 2025
marcelveldt
reviewed
Jan 16, 2025
| dsp = {} | ||
|
|
||
| # player groups have no (explicit) leader since a player group has no audio output | ||
| if not player.provider.startswith("player_group"): |
There was a problem hiding this comment.
the comment seems to imply the reverse of what is happening here?
There was a problem hiding this comment.
I adjusted the comments to be not as confusing.
maximmaxim345
force-pushed
the
feat/dsp-streamdetails
branch
2 times, most recently
from
338c8cb to
9324129
Compare
marcelveldt
force-pushed
the
feat/dsp-streamdetails
branch
from
9324129 to
1e01171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: music-assistant/models#32
Companion Frontend PR: music-assistant/frontend#822
Overview
With this PR, details about the DSP are now attached to
streamdetails, allowing us to display the DSP processing pipeline to the users.Implementation Details
To discern between a user-disabled DSP and a DSP disabled by Music Assistant,
DSPStatewas introduced.The DSP field of
StreamDetailsshould always be up to date, since:DSPConfigDSPDetailsare refreshed in case the number of players in the group changesDSPDetails
DSPDetailsis essentially aDSPConfigwith some adjustments to add dynamic information, enabling the frontend to display the DSP pipeline at any desired level of detail.