Fix: DSP edge cases around groups #1879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various edge cases I missed with #1839.
Reload Detection
The existing logic for issuing DSP reloads when grouping or ungrouping was flawed.
This reworks this section, handling all edge cases I can think of including:
PlayerGroup
sPlayerGroup
with only a single memberAdditionally, the existing logic had another oversight where it would issue a reload command for every device in the group. This fixes that by only reloading the leader/
PlayerGroup
.PlayerGroup
s with single membersAnother previously missed edge case involves groups with single members that would mistakenly use the DSP Config of the
PlayerGroup
instead of thePlayer
. This is now fixed.This now allows all
PlayerGroup
s with single devices to correctly apply DSP.