Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for advanced networking in the Sonos provider. #1885

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

Icelk
Copy link
Contributor

@Icelk Icelk commented Jan 18, 2025

A new advanced config option where the user can specity IPs to the speakers was added.

See the discussion.

Should the documentation about advanced network features be tweaked?

A new advanced config option where the user can specity IPs to the speakers was added.
@Icelk
Copy link
Contributor Author

Icelk commented Jan 18, 2025

The warnings looks like this:

screenshot-2025-01-18-13:55:05


screenshot-2025-01-18-13:54:45

@Icelk
Copy link
Contributor Author

Icelk commented Jan 19, 2025

Force pushed with all your feedback :)

Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Icelk !

@marcelveldt marcelveldt merged commit 4182cb7 into music-assistant:dev Jan 19, 2025
1 check passed
@Icelk
Copy link
Contributor Author

Icelk commented Jan 19, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants