forked from burrowers/garble
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
update modinfo.txt test for 1.18's build and VCS info
That is, use a very specific build tag and git commit, and ensure that neither ends up in the binary. Luckily, we have nothing to do here. We were already removing _gomod_.go from the build entirely, and that is still the mechanism that "go build" uses to bundle the data. Note that the test will still work if git is not installed, but it will simply not check the VCS side. Finally, we use "go version -m" to check the existing fields, which is easier than calling the Go APIs directly. It seems like "go test" passes on yesterday's Go master, now. So, enable test-gotip again with that commit hash. Fixes burrowers#385.
- Loading branch information
1 parent
29356f3
commit 64cbbba
Showing
3 changed files
with
38 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters