Skip to content

Commit

Permalink
v2.0.11 release (#125)
Browse files Browse the repository at this point in the history
* Update server.ts

I found 1 additional bug with VS Code and the data index.  It is missing from the documentation, but it is actually required for it to work.  The bud is that without data set: label,insertText, and documentation work, but detail does not.  If you have multiple items, it uses detail from the last array position for all items.  I also found that the numbers don't do anything for the order of the results returned.  My solution is to use `data: i+1` so that it is handled on the fly.  I know that my VS Code updated a few days ago, so not sure if this is a new bug, because I didn't notice this behavior during my initial testing last week.  I also noticed that the `kind` of icon do not change anymore.

* Update server.ts

Changed code to do a count on Intellisense array before the push to assign a IntellisensePosition var in the push that will increment by 1.  This avoids having to keep track of positions in different parts of the code or trying to statically assign them like 999 trying to stay out of range.  This also avoids the user keeping this correct in their files.  This method should probably also be used in the language and custom words sections.

* Update server.ts

switched to single line `data: Intellisense.length + 1,` in all 3 sections that touch Intellisense (language, customer words, and custom functions)

* Update jBASELanguage.json

removed all occurrences of `index` since it is no longer required.

* Shipping v2.0.11

Co-authored-by: Brent Blair <bblair@encompass.com>
  • Loading branch information
itsxallwater and brentlblair authored Sep 5, 2020
1 parent 43353ed commit bd92d9c
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 410 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,8 @@

### 2.0.10

- Fixed bug with customFunctionPath
- Fixed bug with customFunctionPath

### 2.0.11

- Fixed bug with customFunctionPath and improved jBASELanguage.json
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ This extension would not be possible without the hard work by Grant Hart, Perry
- [@mikes-zum](https://github.com/mikes-zum)
- [@MVDBMS-Solutions](https://github.com/MVDBMS-Solutions)
- [@kpowick](https://github.com/kpowick)
- [@brentlblair](https://github.com/brentlblair)

[code_of_conduct]: https://github.com/mvextensions/.github/blob/master/CODE_OF_CONDUCT.md
[contribution_guidelines]: https://github.com/mvextensions/.github/blob/master/CONTRIBUTING.md
Expand Down
Loading

0 comments on commit bd92d9c

Please sign in to comment.