Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Way to access visitor errors #70

Open
olivierdeckers opened this issue Nov 24, 2016 · 1 comment · May be fixed by #71
Open

Way to access visitor errors #70

olivierdeckers opened this issue Nov 24, 2016 · 1 comment · May be fixed by #71

Comments

@olivierdeckers
Copy link

In the current implementation, errors are logged using slf4j. For example, if a value cannot be found in the context, it is just omitted from the result. I would like to obtain a list of the values that could not be found.

What would be the best way to implement this in your opinion?
@olivierdeckers
Copy link
Author

I added this feature, and created a pull request: #71
I ended up implementing it by adding an optional field to the visitor. If it is defined, errors will be accumulated in it. If it is not defined, nothing will happen. The change should be backwards compatible since I introduced a separate renderStrict method

@olivierdeckers olivierdeckers linked a pull request Nov 25, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strict rendering. Fixes #70 rombit-be/handlebars.scala
1 participant
@olivierdeckers