fix: replace authorization getters and setters with lombok annotations

mxenabled · Dec 11, 2024 · 34c9362 · 34c9362
1 parent f2b3f1a
commit 34c9362
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 145 deletions.
diff --git a/mdx-models/build.gradle b/mdx-models/build.gradle
@@ -1,6 +1,6 @@
 coppuccino {
   coverage {
-    minimumCoverage = 0.10
+    minimumCoverage = 0.12
   }
 }
 

diff --git a/mdx-models/src/main/java/com/mx/path/model/mdx/model/authorization/Authorization.java b/mdx-models/src/main/java/com/mx/path/model/mdx/model/authorization/Authorization.java
@@ -2,12 +2,16 @@
 
 import java.util.List;
 
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
 import com.google.gson.annotations.SerializedName;
 import com.mx.path.model.mdx.model.MdxBase;
 import com.mx.path.model.mdx.model.challenges.Challenge;
 
+@Data
+@EqualsAndHashCode(callSuper = true)
 public class Authorization extends MdxBase<Authorization> {
-
   private String accountId;
   private List<Challenge> challenges;
   private NameValuePair[] cookies;
@@ -16,117 +20,10 @@ public class Authorization extends MdxBase<Authorization> {
   private String deviceId;
   private Long expiresAt;
   private NameValuePair[] headers;
-  private JavaScript javascript;
+  private JavaScript javaScript;
   private String token;
   private NameValuePair[] tokens;
   private String type;
   private String url;
   private String vendorId;
-
-  public Authorization() {
-  }
-
-  public final String getAccountId() {
-    return accountId;
-  }
-
-  public final void setAccountId(String newAccountId) {
-    accountId = newAccountId;
-  }
-
-  public final List<Challenge> getChallenges() {
-    return challenges;
-  }
-
-  public final void setChallenges(List<Challenge> challenges) {
-    this.challenges = challenges;
-  }
-
-  public final NameValuePair[] getCookies() {
-    return cookies;
-  }
-
-  public final void setCookies(NameValuePair[] newCookies) {
-    this.cookies = newCookies;
-  }
-
-  public final String getCookiesUrl() {
-    return cookiesUrl;
-  }
-
-  public final void setCookiesUrl(String cookiesUrl) {
-    this.cookiesUrl = cookiesUrl;
-  }
-
-  public final String getDeviceId() {
-    return deviceId;
-  }
-
-  public final void setDeviceId(String newDeviceId) {
-    accountId = newDeviceId;
-  }
-
-  public final Long getExpiresAt() {
-    return expiresAt;
-  }
-
-  public final void setExpiresAt(Long newExpiresAt) {
-    this.expiresAt = newExpiresAt;
-  }
-
-  public final NameValuePair[] getHeaders() {
-    return headers;
-  }
-
-  public final void setHeaders(NameValuePair[] newHeaders) {
-    headers = newHeaders;
-  }
-
-  public final JavaScript getJavaScript() {
-    return javascript;
-  }
-
-  public final void setJavaScript(JavaScript newJavaScript) {
-    this.javascript = newJavaScript;
-  }
-
-  public final String getToken() {
-    return token;
-  }
-
-  public final void setToken(String newToken) {
-    this.token = newToken;
-  }
-
-  public final NameValuePair[] getTokens() {
-    return tokens;
-  }
-
-  public final void setTokens(NameValuePair[] tokens) {
-    this.tokens = tokens;
-  }
-
-  public final String getType() {
-    return type;
-  }
-
-  public final void setType(String newType) {
-    this.type = newType;
-  }
-
-  public final String getUrl() {
-    return url;
-  }
-
-  public final void setUrl(String newUrl) {
-    url = newUrl;
-  }
-
-  public final String getVendorId() {
-    return vendorId;
-  }
-
-  public final void setVendorId(String newVendorId) {
-    accountId = newVendorId;
-  }
 }
diff --git a/mdx-models/src/main/java/com/mx/path/model/mdx/model/authorization/HtmlPage.java b/mdx-models/src/main/java/com/mx/path/model/mdx/model/authorization/HtmlPage.java
@@ -1,14 +1,14 @@
 package com.mx.path.model.mdx.model.authorization;
 
 import lombok.Data;
+import lombok.EqualsAndHashCode;
 
 import com.mx.path.model.mdx.model.MdxBase;
 import com.mx.path.model.mdx.model.MdxNested;
 
 @MdxNested
 @Data
+@EqualsAndHashCode(callSuper = true)
 public class HtmlPage extends MdxBase<HtmlPage> {
-
   private String content;
-
 }
diff --git a/mdx-models/src/main/java/com/mx/path/model/mdx/model/authorization/JavaScript.java b/mdx-models/src/main/java/com/mx/path/model/mdx/model/authorization/JavaScript.java
@@ -1,27 +1,15 @@
 package com.mx.path.model.mdx.model.authorization;
 
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
 import com.mx.path.model.mdx.model.MdxBase;
 import com.mx.path.model.mdx.model.MdxNested;
 
 @MdxNested
+@Data
+@EqualsAndHashCode(callSuper = true)
 public class JavaScript extends MdxBase<JavaScript> {
-
   private NameValuePair[] arguments;
   private String functionToInvoke;
-
-  public final NameValuePair[] getArguments() {
-    return arguments;
-  }
-
-  public final void setArguments(NameValuePair[] newArguments) {
-    this.arguments = newArguments;
-  }
-
-  public final String getFunctionToInvoke() {
-    return functionToInvoke;
-  }
-
-  public final void setFunctionToInvoke(String newFunctionToInvoke) {
-    this.functionToInvoke = newFunctionToInvoke;
-  }
 }
diff --git a/mdx-models/src/main/java/com/mx/path/model/mdx/model/authorization/NameValuePair.java b/mdx-models/src/main/java/com/mx/path/model/mdx/model/authorization/NameValuePair.java
@@ -1,26 +1,15 @@
 package com.mx.path.model.mdx.model.authorization;
 
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
 import com.mx.path.model.mdx.model.MdxBase;
 import com.mx.path.model.mdx.model.MdxNested;
 
 @MdxNested
+@Data
+@EqualsAndHashCode(callSuper = true)
 public class NameValuePair extends MdxBase<NameValuePair> {
   private String name;
   private String value;
-
-  public final String getName() {
-    return name;
-  }
-
-  public final void setName(String newName) {
-    this.name = newName;
-  }
-
-  public final String getValue() {
-    return value;
-  }
-
-  public final void setValue(String newValue) {
-    this.value = newValue;
-  }
 }