This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Scrollable, collapsible menu #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I though about it and added a toggle in settings to revert back to the old way of displaying it. I also fixed a bug that after changing settings an error would show in journalctl that slider has been already disposed. |
|
So I think this also fixes #22 |
|
Thanks for this! Unfortunately it will take me a few weeks before I have any time to review.
…-------- Original message --------
From: echooff2 ***@***.***>
Date: 4/17/23 4:37 PM (GMT-06:00)
To: mymindstorm/gnome-volume-mixer ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [mymindstorm/gnome-volume-mixer] Scrollable, collapsible menu (PR #34)
So I think this also fixes #22<#22>
—
Reply to this email directly, view it on GitHub<#34 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGUAT3TZ7X26GSGJ2LJ5OX3XBWZ3DANCNFSM6AAAAAAXAIGPVU>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts all app streams into one submenu. If there is too many of them scrollbar will appear.
Collapsed:
Open:
Fixes #11 and #27