Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device gain settings #391

Merged
merged 26 commits into from
Jan 9, 2024
Merged

Add device gain settings #391

merged 26 commits into from
Jan 9, 2024

Conversation

DominykasPetke
Copy link

Added

  • Device gain settings.

Fixed

  • LMS_GetAntennaList not returning the actual antennae count.
  • Minor memory issues.

@DominykasPetke
Initial gain information saving implementation
b45c203
@DominykasPetke
Clean up some small things in the actual gain functions
bbddf86
@DominykasPetke
Change parameter to a pointer to save on memory
d44a5d4
@DominykasPetke
Implement SetGain/GetGain
0885065
@DominykasPetke
Copy in functions from the old code, refactor saved config value
252d610
@DominykasPetke
Add the RFSoC values to other devices as well
aa1d791
@DominykasPetke
Fix actual dB values
2260671
@DominykasPetke
Add the frontend GUI elements for gain control
f80448a
@DominykasPetke
Fix value not being set in the default behaviour state in LMS7002M_SD…
a3130cb 
…RDevice::GetGain
@DominykasPetke
Clean up memory issues
fa35ba1
@DominykasPetke
Only update the gain values if that gain's type was changed
a7c9594
@DominykasPetke
Fix LMS_GetAntennaList not returning the actual antenna count
a44d618
@DominykasPetke
Clean up TODOs
9f6ec2a
@DominykasPetke
Fix wrong module indexes being given in MMX8 Set/GetGain functions
827eb63
@DominykasPetke
Split SetGain generic path into separate functions
ae7fcd2
@DominykasPetke
Move the gain tables outside the function
361e30a
@DominykasPetke
Reduce duplication and add documentation
d573eb3
@DominykasPetke
Separate GUI setters into a function
1721625
@DominykasPetke
Deduplicate a memory cleanup function
ffd02fe
@DominykasPetke DominykasPetke changed the title Adding device gain settings Add device gain settings Jan 5, 2024
rjonaitis
rjonaitis requested changes Jan 5, 2024
View reviewed changes
src/include/limesuite/GainTypes.h Outdated Show resolved Hide resolved
src/protocols/TRXLooper.h Outdated Show resolved Hide resolved
src/boards/LimeSDR/LimeSDR.cpp Outdated Show resolved Hide resolved
src/comms/PCIe/TRXLooper_PCIE.cpp Outdated Show resolved Hide resolved
src/include/limesuite/SDRDevice.h Outdated Show resolved Hide resolved
src/include/limesuite/SDRDevice.h Outdated Show resolved Hide resolved
src/include/limesuite/SDRDevice.h Outdated Show resolved Hide resolved
@DominykasPetke
Deduplication, var renames, consistency fixes
3b9f614
@DominykasPetke
Remove duplicate initializations
5270ee3
@DominykasPetke
Reduce nesting
6f40518
@DominykasPetke
Revert memory alignment changes.
e90a621 
This code was technically invalid in C(++)11, since "the `size` parameter must be an integral multiple of alignment." However, since [DR460](https://open-std.org/JTC1/SC22/WG14/www/docs/summary.htm#dr_460), and hence, since C(++)17, this is now actually valid.
@DominykasPetke
Fix GUI elements after changing int to float
fee3a04
@rjonaitis
Copy link
Member

Shared libraries build fails with link errors.

@rjonaitis rjonaitis merged commit 607f6b9 into myriadrf:litepcie-update Jan 9, 2024
1 check passed
@DominykasPetke DominykasPetke deleted the litepcie-update-gains branch January 9, 2024 13:13
DominykasPetke pushed a commit to Matom-ai/LimeSuite that referenced this pull request Mar 28, 2024
@rjonaitis
Merge pull request myriadrf#391 from Matom-ai/litepcie-update-gains
3e59c74 
Add device gain settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjonaitis rjonaitis rjonaitis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominykasPetke @rjonaitis